search

dhojayev / traderepublic-portfolio-downloader

App that downloads transactions and PDF documents from Trade Republic depot
GNU General Public License v3.0
14 stars 0 forks source link

Implement downloading non-transactional PDF documents, aka "Aktivität" #33

Closed dhojayev closed 2 months ago

dhojayev commented 3 months ago

Is your feature request related to a problem? Please describe. We currently only download PDF documents attached to transactions. There are still many other documents that would be great to grab automatically, such as yearly tax report, Vorabpauschale, etc.

Describe the solution you'd like Activity related documents shall be saved in "activity" directory and also be split by months.

dhojayev commented 3 months ago

Hey @tenjaa, I implemented non-transactional documents downloading. Could you maybe test it, that would help a lot as it seems that you have a very rich on data account :) https://github.com/dhojayev/traderepublic-portfolio-downloader/actions/runs/9538802249

dhojayev commented 3 months ago

Hey @martinAtGitHub, maybe you wanna test it as well. Any input could help bughunting. Thanks in advance!

dhojayev commented 3 months ago

@dmagur please check it too

dmagur commented 3 months ago

fails on this "action": { "payload": { "verificationTransfer": false }, "type": "redirectCashAccountScreen" },

dhojayev commented 3 months ago

fails on this "action": { "payload": { "verificationTransfer": false }, "type": "redirectCashAccountScreen" },

Thanks for checking. I just pushed a fix for that. Please download and run it again: https://github.com/dhojayev/traderepublic-portfolio-downloader/actions/runs/9550191630

dhojayev commented 2 months ago

@dmagur has confirmed that it is working now so I will release it.

tenjaa commented 2 months ago

@dhojayev I also gave it (latest release where this was merged) a try. My activity log tells me skipped: 20 so some seem to be missing, but most of them worked.

Not a problem for me, but if you want to dig deeper just tell me what data you need :)

dhojayev commented 2 months ago

@dhojayev I also gave it (latest release where this was merged) a try.

My activity log tells me skipped: 20 so some seem to be missing, but most of them worked.

Not a problem for me, but if you want to dig deeper just tell me what data you need :)

Hey @tenjaa! Thanks for your reply. Skipped entries are expected since not all activity entries in your account have documents and we ignore those entities. But I am happy to hear that it worked without any errors on your end.