dhojayev / traderepublic-portfolio-downloader

App that downloads transactions and PDF documents from Trade Republic depot
GNU General Public License v3.0
21 stars 0 forks source link

Unsupported transaction skipped ("eventType": "SAVINGS_PLAN_EXECUTION_FAILED") #46

Open louim-lbs opened 3 weeks ago

louim-lbs commented 3 weeks ago

Describe the bug "eventType": "SAVINGS_PLAN_EXECUTION_FAILED" seems not to be recognized. I have the Unsupported transaction skipped warning.

Expected behavior Don't take into account (or yes, I don't know) the operation, cause it failed, but at least recognize it and don't return a warning that let me think there is something wrong.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context

Ex of timelineTransactions related transaction:

{
      "action": {
        "payload": "********-****-****-****-************",
        "type": "timelineDetail"
      },
      "amount": {
        "currency": "EUR",
        "fractionDigits": 2,
        "value": -1
      },
      "badge": null,
      "eventType": "SAVINGS_PLAN_EXECUTION_FAILED",
      "icon": "logos/US0378331005/v2",
      "id": "********-****-****-****-************",
      "status": "CANCELED",
      "subAmount": null,
      "subtitle": "Unzureichende Mittel",
      "timestamp": "2024-09-**T**:**:02.856+0000",
      "title": "Apple"
    }

Ex of timelineDetailV2 related file:

{
  "id": "********-****-****-****-************",
  "sections": [
    {
      "action": {
        "payload": "US0378331005",
        "type": "instrumentDetail"
      },
      "data": {
        "icon": "logos/US0378331005/v2",
        "status": "canceled",
        "subtitleText": null,
        "timestamp": "2024-09-**T**:**:02.856+0000",
      },
      "title": "Du hast 1,00 € investiert",
      "type": "header"
    },
    {
      "action": null,
      "data": [
        {
          "detail": {
            "functionalStyle": "CANCELED",
            "text": "Fehlgeschlagen",
            "type": "status"
          },
          "style": "plain",
          "title": "Status"
        },
        {
          "detail": {
            "action": null,
            "text": "Unzureichende Mittel",
            "trend": null,
            "type": "text"
          },
          "style": "plain",
          "title": "Grund"
        },
        {
          "detail": {
            "action": null,
            "text": "Sparplan",
            "trend": null,
            "type": "text"
          },
          "style": "plain",
          "title": "Orderart"
        },
        {
          "detail": {
            "action": null,
            "text": "Apple",
            "trend": null,
            "type": "text"
          },
          "style": "plain",
          "title": "Asset"
        },
        {
          "detail": {
            "icon": "logos/bank_traderepublic/v2",
            "text": "Guthaben",
            "type": "iconWithText"
          },
          "style": "plain",
          "title": "Zahlung"
        }
      ],
      "title": "Übersicht",
      "type": "table"
    },
    {
      "action": null,
      "data": [
        {
          "detail": {
            "action": {
              "payload": {
                "savingsPlanId": "********-****-****-****-************"
              },
              "type": "openSavingsPlanOverview"
            },
            "amount": "1,00 €",
            "icon": "logos/US0378331005/v2",
            "status": "executed",
            "subtitle": "Wöchentlich",
            "timestamp": "2024-09-**T**:**:02.856+0000",
            "title": "Apple",
            "type": "embeddedTimelineItem"
          },
          "style": "plain",
          "title": ""
        }
      ],
      "title": "Sparplan",
      "type": "table"
    },
    {
      "action": null,
      "data": [
        {
          "action": {
            "payload": "https://traderepublic-data-production.s3.eu-central-1.amazonaws.com/timeline/postbox/***",
            "type": "browserModal"
          },
          "detail": "23.09.2024",
          "id": "********-****-****-****-************",
          "postboxType": "SAVINGS_PLAN_EXECUTION_FAILED_V2",
          "title": "Ausführung Fehlgeschlagen"
        }
      ],
      "title": "Dokumente",
      "type": "documents"
    }
  ]
}

Thanks!

dhojayev commented 3 weeks ago

Hey @louim-lbs, Thanks for new data. I think these transactions have to be skipped by design, because they are failed transactions, which means you have not spent nor have you received any money. It is possible to include them with the failed status and maybe the reason from TR. But then I will prioritize it lower as it is not core functionality of this app.

louim-lbs commented 3 weeks ago

Hey, Yes I agree with the skip, but maybe it could be interesting to acknowledge them, not to let think the user it is a missed operation. Like changing Unsupported transaction skipped to Failed (null) transaction skipped, or something similar. Anyway, no big deal, as you mentioned. Best,

dhojayev commented 3 weeks ago

You are right. I think it is better to say explicitly that it was deliberately ignored, to not raise a confusion. I will work on that. Thanks again for your help!