Mb #35 data provider - Githubissues

dhoko / angular-ngBabelfish

Internationalization module for angular.js, it's magic !

MIT License

11 stars 3 forks source link

Closed mbertin closed 9 years ago

mbertin commented 9 years ago

Test are missing not really ready for PR

dhoko commented 9 years ago

Top !

Can you add some tests and documentation in the readme ?

mbertin commented 9 years ago

Sure, I will.

dhoko commented 9 years ago

Also your modification is for the lazy mode. It has to be available !lazy mode

mbertin commented 9 years ago

Test and non lazy mode done => PR OK

mbertin commented 9 years ago

Complete readme and remove empty test

dhoko commented 9 years ago

Can you change the version in package.json and bower.json to 1.7.0 ? It's not a patch.

run node version.js 1.7.0.

dhoko commented 9 years ago

Thank you :+1: