search

dhoko / angular-ngBabelfish

Internationalization module for angular.js, it's magic !
MIT License
11 stars 3 forks source link

Add debug #40

Closed Aldorus closed 9 years ago

Aldorus commented 10 years ago

The debug mode to false remove alert notification in load i18n translation

dhoko commented 10 years ago

Thanks ! The debug mode is a good idea.

Before the merge:

  1. You must edit the source not bundle.
  2. Add a tests for: Pop an alert if error without debug, and Do not pop and alert if error with debug
  3. Run npm test if it works
  4. npm run build (You need to have UglifyJS in global)
  5. Edit the readme to add some documentation for this feature
Aldorus commented 10 years ago

1 : Can you push the src/ files ;) 2 : Ok i will do when i have src/ 3 : Ok i will do when i have src/ 4 : Ok i will do when i have src/ 5 : Already done

mbertin commented 10 years ago

src/ files are in i18n folder ;)

Aldorus commented 10 years ago

obviously

dhoko commented 10 years ago

Yup it's a bad idea, fixed in #37

5 : Already done

Nop, it's not. This is API documentation.

debug: true // By default this value is false, put to true if you want information about debug

It's nice but you need to explain how to use it and why cf log system in dev

Aldorus commented 10 years ago

Ok i will do this ;=)