dholroyd / h264-reader

Rust reader for H264 bitsream syntax
Apache License 2.0
72 stars 25 forks source link

add gortsplib sps tests #40

Closed Curid closed 1 year ago

Curid commented 1 year ago

This is all the gortsplib sps tests if you want them.

dholroyd commented 1 year ago

I think apart from the tests, the only non-formatting change is the addition of the fps() method, right? (In future consider putting the rustfmt changes in a separate commit for easier review - and yeah I confess I should have run rustfmt myself - and enforce it in CI!)

Curid commented 1 year ago

Sorry about the formatting. I can make two separate PRs for cargo fmt and cargo clippy first if you want.

gortsplib has a fps() method and tests for it. I don't think I have a use for it personally, would you like me to remove it?

dholroyd commented 1 year ago

I am happy to keep fps() in this PR.