dholroyd / h264-reader

Rust reader for H264 bitsream syntax
Apache License 2.0
72 stars 25 forks source link

`rbsp` module changes #81

Open scottlamb opened 1 month ago

scottlamb commented 1 month ago

See commit descriptions.

You might have seen that I did something dumb earlier—accidentally pushed a version of this directly to the dholroyd/h264-reader repo's master branch. I force-pushed over it a few minutes later—generally not a good idea either but seemed like the least bad thing under the circumstances. Sorry for the mess. Might be worth setting up branch protection to prevent the accident-prone person (me) from doing something like that again...

github-actions[bot] commented 1 month ago

🐰Bencher

ReportMon, August 12, 2024 at 23:58:52 UTC
Projecth264-reader
Branch81/merge
Testbedlocalhost

⚠️ WARNING: The following Measures do not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Instructions (instructions)
  • L1 Hits (l1-hits)
  • L2 Hits (l2-hits)
  • RAM Hits (ram-hits)
  • Total read+write (total-read-write)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkEstimated CyclesEstimated Cycles Results
estimated cycles | (Δ%)
InstructionsInstructions Results
instructions
L1 HitsL1 Hits Results
hits
L2 HitsL2 Hits Results
hits
RAM HitsRAM Hits Results
hits
Total read+writeTotal read+write Results
reads/writes
ci_bench::ci::reader read:setup_video("big_buck_bunny_1080p_24fps_h264.h264"...✅ (view plot)16,619,076.00➖ (view plot)8,162,349.00➖ (view plot)10,750,146.00➖ (view plot)14,943.00➖ (view plot)165,549.00➖ (view plot)10,930,638.00

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
scottlamb commented 1 week ago

@dholroyd would you like to take a look at this before I merge? I'll need your help anyway publishing to cargo, as I don't have permissions for that.