search

dhood / dhood.github.io

Other
0 stars 2 forks source link

Added slideshow of school talk testimonials #8

Closed CharlzGaldo closed 8 months ago

CharlzGaldo commented 8 months ago

It Should be working fine, let me know if you find anything wrong or needs changing. I had to change some "class" names in the code for the slideshow like fade -> fades and active -> actives because it was already used in previous code and changed code that was already written.

dhood commented 8 months ago

@CharlzGaldo this is awesome! looks incredible, and it's something that I have never done myself and now can learn from you :sunglasses: how cool.

Can you make it smaller, please? maybe about 70% of its current size? and smaller on mobile, because it currently is disproportionately large: image

CharlzGaldo commented 8 months ago

My browser doesn't show the mobile device view properly so please LMK if the problem is fixed.

dhood commented 8 months ago

it is fixed! although the font size of the description text is a bit too big: Screenshot from 2024-02-13 10-43-56

Can you please remove the description text, altogether? can it be left blank? (ps to get it to switch to mobile view I just make my browser window skinnier and once the width is less than a certain amount it switches modes :+1: )

You have encountered a new challenge accidetnally which is a "merge conflict". Have a google and try to fix it! if anything goes wrong, I will be able to restore the current state of the branch from my local version. LMK where you get stuck :slightly_smiling_face:

CharlzGaldo commented 8 months ago

Nice! I found a way to make it go to mobile view on my end now. I removed the text but I don't know if I fixed the merge conflict correctly 😅 Hopefully I didn't break anything.

dhood commented 8 months ago

nice work fixing the merge conflict.. that is a very useful skill. hopefully we get to practice it some more!