dhoss / catalyst-view-email

how does this not exist
3 stars 8 forks source link

Subject Encoding generates error in Email::Simple #15

Open moseschmiedel opened 3 years ago

moseschmiedel commented 3 years ago

Email::Simple requires the subject header not to be folded (it should not include vertical whitespace, like for example newlines) before passing it to the Email::Simple::process method. But in the Catalyst::View::Email::process method the subject gets folded when passed to Encode::encode. This will be a fatal error in future versions of Email::Simple and should be fixed!

I see 2 solutions:

  1. I also file a bug report at Encode::encode and they introduce a way to encode MIME-Headers without folding, which then can be used in Catalyst::View::Email::process to bypass the warning of Email::Simple.
  2. Or another encoding method gets used in Catalyst::View::Email::process which doesn't fold the base64 String

In case of questions please ask me contact me. If you need more Information, feel free to also contact me.

karpet commented 3 years ago

I think this module has been abandoned. If the Catalyst maintainers want to adopt it, that would be appreciated.

https://github.com/dhoss/catalyst-view-email/issues/10#issuecomment-233457711

dboehmer commented 3 years ago

I added a workaround for this to our application’s code in https://github.com/dboehmer/coocook/commit/84557c8412dea46b568e28dcf4fd2f702ea56072.