mod_lib_ldap: Report bind failures

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Setup ldap with a wrong bind_password

What is the expected output? What do you see instead?
I would like to see: "LDAP bind failed - server result: ..."
But I get instead:
mod_c2s: Traceback[c2s]: /usr/lib/prosody/modules/ldap.lib.lua:217: attempt to 
index local 'ld' (a nil value)_stack trac
eback:__/usr/lib/prosody/modules/ldap.lib.lua:217: in function 
'singlematch'__/usr/lib/prosody/modules/mod_storage_ldap.lua:154: in function 
'get'
__/usr/lib/prosody/modules/mod_vcard.lua:25: in function 
'?'__/usr/lib/prosody/util/events.lua:67: in function 
</usr/lib/prosody/util/events.lua:6
3>__(tail call): ?__/usr/lib/prosody/modules/mod_iq.lua:38: in function 
'?'__/usr/lib/prosody/util/events.lua:67: in function 'fire_event'__/usr/l
ib/prosody/core/stanza_router.lua:184: in function 
'core_post_stanza'__/usr/lib/prosody/core/stanza_router.lua:132: in function 
</usr/lib/prosody/
core/stanza_router.lua:55>__(tail call): 
?__...__/usr/lib/prosody/util/xmppstream.lua:185: in function 
'feed'__/usr/lib/prosody/modules/mod_c2s.lu
a:230: in function 'data'__/usr/lib/prosody/modules/mod_c2s.lua:252: in 
function 'onincoming'__/usr/lib/prosody/net/server_event.lua:625: in funct
ion </usr/lib/prosody/net/server_event.lua:571>__[C]: in function 
'loop'__/usr/lib/prosody/net/server_event.lua:786: in function </usr/lib/prosody
/net/server_event.lua:785>__[C]: in function 
'xpcall'__/usr/lib/prosody/../../bin/prosody:372: in function 
'loop'__/usr/lib/prosody/../../bin/pros
ody:402: in main chunk__[C]: ?

Original issue reported on code.google.com by devuran...@gmx.net on 26 Jan 2014 at 1:38

[nh2]

Note that this error message also appears when the LDAP server isn't even reachable, e.g. when there's nothing listening on port 389 at all!