fix: globs with backslashes (like Windows paths) break chokidar

dhoulb / gatsby-plugin-templated-files

DEPRECATED: Plugin is no longer supported

BSD Zero Clause License

5 stars 1 forks source link

fix: globs with backslashes (like Windows paths) break chokidar #2

Closed dmliao closed 5 years ago

dmliao commented 5 years ago

As per https://github.com/paulmillr/chokidar/issues/777, chokidar can't watch globs with backslashes, which is the default separator for path on Windows.

This is a not-terribly-elegant fix for that that simply replaces the backslashes with forward slashes. I used it to get my project up and running, but any feedback is welcome.

dhoulb commented 5 years ago

@dmliao Looks good to me! I hadn't tested this package on Windows (I was trusting path to do the right thing), so thank you!

Does it work well apart from this one issue?

dhoulb commented 5 years ago

:tada: This PR is included in version 1.2.1 :tada:

The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket: