dhoulb / multi-semantic-release

Proof of concept that wraps semantic-release to work with monorepos.
BSD Zero Clause License
203 stars 36 forks source link

question: plan or thought on upgrading to latest semantic-release version #103

Closed Badisi closed 2 years ago

Badisi commented 2 years ago

Currently this package is using : "semantic-release": "^17.4.7" whereas the latest is 19.0.2.

I've had an issue with semantic-release (#2407) that might be fixed one day (hopefully ^^). And if so, I was wondering what's the current plan or thought for MSR to upgrade to the latest SR version ?

Thanks!

antongolub commented 2 years ago

Migration to semrel v19 is a reasonable change, no doubts. I see several options: 1) Declare semrel as a peer dependency (breaking change, requires manual install) 2) Update semrel to v19 (breaking change, requires node v14+) 3) Install semrel on-fly (complex) 4) Install both v17 and v19 (aliases + bundled deps?, complex)

Anyway, I think we should configure v2 branch to release only for patches and vulns fixes to support our users who still need old nodejs versions for some reasons.

Badisi commented 2 years ago

I would go with 2. and release a v3 with semrel v19 as a dep and node engine >=16 || ^14.17 to follow semrel.

janpe commented 2 years ago

Hello @antongolub! Do you see one of these options happening sometime soon? There are currently bunch of vulnerabilities in the dependencies.

Tried something in this pull #122 request but not quite sure how to deal with the error in the CI job.

antongolub commented 2 years ago

There's an issue with one test, which seems related to npm changes: everything is fine in Node16 / npm 8.5.0 and fails in Node 18.8.0 / npm 8.18.0. I'm afraid I have not enough time to figure out what exaclty went wrong, so I just disabled the test case.

antongolub commented 2 years ago

:tada: This issue has been resolved in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

janpe commented 2 years ago

Awesome, thanks! 👏

Badisi commented 2 years ago

@antongolub, tests are fixed in #124 😉

@janpe, thanks for helping releasing this feature! 🎉