search

dhoulb / multi-semantic-release

Proof of concept that wraps semantic-release to work with monorepos.
BSD Zero Clause License
203 stars 36 forks source link

feature request: also bump deps in package distribution folder #105

Closed Badisi closed 2 years ago

Badisi commented 2 years ago

Consider the following:

root
└── dist
    ├── A
    └── B
└── projects
    ├── A
    └── B (depends on A)

When releasing both A and B, MSR will eventually find that A needs to be updated in B's deps. It will even include a note for that in B's release notes: "Dependencies A: upgraded to x.x.x". Which is a great feature!

But in my case both A and B where built to a dist folder prior to running MSR. And the package.json that MSR will actually updates (in updateDeps.js#L311) is projects/B/package.json not dist/B/package.json which is the one that needs to be updated before publishing.

Would it be possible to also look for the pkgRoot option of @semantic-release/npm and made the changes in there too ?

Thanks!

antongolub commented 2 years ago

:tada: This issue has been resolved in version 2.12.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: