dhoulb / multi-semantic-release

Proof of concept that wraps semantic-release to work with monorepos.
BSD Zero Clause License
203 stars 36 forks source link

feat(#105): also bump deps in package distribution folder #106

Closed Badisi closed 2 years ago

Badisi commented 2 years ago

Closes #105

Badisi commented 2 years ago

@antongolub, what about now ?

Badisi commented 2 years ago

@antongolub, I refactored a bit to check against '.' as you requested and added some tests.

antongolub commented 2 years ago

Hey @Badisi,

I'll take a look in the next 24h.

antongolub commented 2 years ago

Everything seems fine. I'll merge this next morning to be able to rollback if needed.

antongolub commented 2 years ago

:tada: This PR is included in version 2.12.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

antongolub commented 2 years ago

@Badisi,

Merged. Could you plz make a couple tweak ups?

  1. Introduce getRootPkgs(context) helper:
    const getRootPkgs = (context, ...extra) => getPkgRootOptions(context).map((pkgRoot) => {
    const manifestPath = cleanPath(`${pkgRoot}/package.json`, context.cwd);
        return {
            path: manifestPath,
            manifest: getManifest(manifestPath),
            ...extra, // _depsChanged: pkg._depsChanged,
        };
    }),
  2. Rename getPkgRootOptions to getRootPkgs to define both helpers in one place.
  3. Add some notes about config.pkgRoot. Docs ref would be ok.
Badisi commented 2 years ago

Done in PR #109