Preserve trailing newline and don't include unnecessary dependency fields in package.json

[cherryblossom000]

I had a package.json like this:

{
  "name": "test",
  "version": "1.1.0",
  "dependencies": {
    "foo": "*"
  },
  "devDependencies": {
    "bar": "*"
  }
}

The file had a trailing newline.

After triggering a release, multi-semantic-release converted package.json to:

{
  "name": "test",
  "version": "1.1.0",
  "dependencies": {
    "foo": "*"
  },
  "devDependencies": {
    "bar": "*"
  },
  "peerDependencies": {},
  "optionalDependencies": {}
}

without a trailing newline.

I know this isn't that important — I could always make a plugin that removes these fields and adds the trailing newline — but it would be nice for multi-semantic-release to preserve trailing newlines and remove empty dependency fields before writing package.json because I commit the updated package.json using @semantic-release/git.

[antongolub]

@cherryblossom000

It's reasonable and doesn't look complicated. Should we implement this proposal or you'd like to make a pull request?

[antongolub]

I suggest to create a separate file and also to move indent resolver into it.

recognizeFormat = (content) => {
  const indent = ...
  const eofTrailing = ...

  return {
    indent,
    eofTrailing
  }
}

[cherryblossom000]

@antongolub I'll work on this.

[antongolub]

Great. I'm going to make a small fix: msr doesn't seem to update optional dependencies.

[antongolub]

@cherryblossom000

I fixed the manifest patching: now scopes are not added to package.json if they were not there initially.

[dhoulb]

:tada: This issue has been resolved in version 2.4.4 :tada:

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot :package::rocket: