resolveNextVersion should provide bumpStrategy instead of releaseStrategy

dhoulb / multi-semantic-release

Proof of concept that wraps semantic-release to work with monorepos.

BSD Zero Clause License

203 stars 36 forks source link

Closed zhbhun closed 3 years ago

zhbhun commented 3 years ago

resolveNextVersion(currentVersion, nextVersion, strategy = "override")'s strategy accept bump strategy: inherit, override, satisfy`, but getDependentRelease invoke resolveNextVersion with release strategy: patch, minor, major, inherit.

antongolub commented 3 years ago

Hey, @zhbhun,

Good catch, thanks! Could you also:

rename fn param to clarify the passed strategy type: strategy = "override" → bumpStrategy = "override"
remove releaseStrategy arg from getDependentRelease(pkg, bumpStrategy, releaseStrategy, ignore). It seems useless after the fix. ?

zhbhun commented 3 years ago

Sure!

strategy is rename to bumpStrategy.
releaseStrategy is used to resolveReleaseType that is called in getDependentRelease.

antongolub commented 3 years ago

Great. Thanks!

antongolub commented 3 years ago

:tada: This PR is included in version 2.8.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: