search

dhoulb / multi-semantic-release

Proof of concept that wraps semantic-release to work with monorepos.
BSD Zero Clause License
203 stars 36 forks source link

[BUG] can't resolve workspace packages on windows #80

Closed francescocaveglia closed 3 years ago

francescocaveglia commented 3 years ago

Windows paths with \\ separator are not resolved

To fix this https://github.com/dhoulb/multi-semantic-release/blob/7012e656736e806a1a9e01293de6440f40e69723/lib/getPackagePaths.js#L39

should be 


packages.map((p) => p.replace(/\\/, '/').replace(/\/?$/, "/package.json")),
antongolub commented 3 years ago

Hmm... Or maybe it's better to use unixify.

antongolub commented 3 years ago

:tada: This issue has been resolved in version 2.9.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

antongolub commented 3 years ago

Hey, @francescocaveglia

Could you check v2.9.1?

francescocaveglia commented 3 years ago

Hey, @francescocaveglia

Could you check v2.9.1?

Working fine! Thanks!