search

dhowden / tag

ID3, MP4 and OGG/FLAC metadata parsing in Go
BSD 2-Clause "Simplified" License
558 stars 73 forks source link

Sanity check #12

Closed xhenner closed 9 years ago

xhenner commented 9 years ago

There is no guaranty that we are at the start of the file

dhowden commented 9 years ago

This is a good point: in several places I would seek to the beginning of the ReadSeeker (and this is not documented). This removes some of the flexibility that comes with using a ReadSeeker (instead of an os.File for instance where you could assume that it was just an audio file).

I have removed all Seeks to "absolute" 0, so that the caller can set the initial state of the ReadSeeker before passing it through to tag: 6df4e78.