search

dhowden / tag

ID3, MP4 and OGG/FLAC metadata parsing in Go
BSD 2-Clause "Simplified" License
568 stars 77 forks source link

Add comment tag #40

Closed jooola closed 6 years ago

jooola commented 6 years ago

Still need some more testing. But functions are here.

jooola commented 6 years ago

Yup, thanks for pointing this out, this was still a WIP. Will fix any time soon !

jooola commented 6 years ago

I would appreciate if we squash and merge the "Testing" PR, so I can keep the tests up to date with this PR as well.

dhowden commented 6 years ago

Great, can merge this now. Re: Testing PR: Not sure what you mean? Do you want to merge that in first?

jooola commented 6 years ago

I suggest you merge #41 first and I'll pull from master and squash this PR so I can perfom some testing for the Comment interface. I'm a bit lazzy I could merge it locally. But I think it's better if we try to get testing in first.