search

dhowden / tag

ID3, MP4 and OGG/FLAC metadata parsing in Go
BSD 2-Clause "Simplified" License
558 stars 73 forks source link

Add test_tag and some sample data #41

Closed jooola closed 5 years ago

jooola commented 6 years ago

Add some testing in the library.

Never had the chance to write test, so if you see something outrageous in the code, tell me.

We go up to 40,5% of test coverage.

dhowden commented 6 years ago

Looks like the tests are failing in Travis? Can you fix?

jooola commented 6 years ago

Yes sure, it's failling because the VorbisComment date is still not implemented in this PR. I'll pull from master and squash it.

jooola commented 6 years ago

I would squash this PR and merge it ! Should be ok now.

jooola commented 6 years ago

Sorry if I'm changing the test file every time I need to fix something. But those change are always improvements.

The test fails on 3 mp3id3v11 tags. I think we should rework the way id3v11 string tags are read because it add many empty chars. image

jooola commented 6 years ago

IMO this is ready to be merged.

jooola commented 5 years ago

Ping

dhowden commented 5 years ago

Apologies, been busy with other things. Looking at this now.