search

dhowden / tag

ID3, MP4 and OGG/FLAC metadata parsing in Go
BSD 2-Clause "Simplified" License
558 stars 73 forks source link

multiple data atoms can cause size overflow and hang #51

Closed steve-hellwege-wdc closed 5 years ago

steve-hellwege-wdc commented 5 years ago

I will be modifying this shortly to add full support for multiple data atoms.

steve-hellwege-wdc commented 5 years ago

Updated PR to support multiple data atoms. Updated sample.mp4 with tag "release type", which contains multiple data atoms.

dhowden commented 5 years ago

Thanks for the contribution!

I'm pretty busy at the moment, but will hopefully get to look at this in a few days.

One thing though: the context change is API-breaking, so I would definitely put that in a seperate PR. It seems a little off though, maybe instead we should consider setting limits on the size of metadata we will look at (if you're worried about it taking too long).

dhowden commented 5 years ago

This pull request is to address #50

steve-hellwege-wdc commented 5 years ago

Thanks, I agree, was thinking of removing the context change completely, which I will do.

steve-hellwege-wdc commented 5 years ago

Thanks for the contribution!

I'm pretty busy at the moment, but will hopefully get to look at this in a few days.

Hi, if you are able to take a look at the change that would be much appreciated! Thanks.