dhowden / tag

ID3, MP4 and OGG/FLAC metadata parsing in Go
BSD 2-Clause "Simplified" License
558 stars 72 forks source link

fix: fix id3v2 sum error #96

Open yinhylin opened 1 year ago

ghost commented 1 year ago

@dhowden An mp3 file can have both ID3v1 and ID3v2 tags. This seems to be common on Linux as I've gotten many files that have both. Currently, for files that have both, Sum includes the IDv1 tags in the Sum when it shouldn't.

Also, I believe ID3v2.4 allows the frames to be at the end or beginning of a file, but the library always assumes it's at the beginning.

@yinhylin Thanks for doing this. This is one of the things that I needed. The last consideration is XING headers (like the LAME header) and whether that should be included in the Sum or not.