Tests before 1st release

[Real-John-Cheung]

@dhowe I think now we are ready for the before release test. I have tested in a few websites on firefox and chrome (mainly on a win64 machine). Could you create a list here for what tests should be done? and maybe @MelodyneedsMoney can also help with this.

[dhowe]

I think I can do the first round of testing, as I know what the desired behavior is. After that we can create a list of things to check for a new release (which I'll start here):

-- Verify all tests pages (with ads) show at least one poem replacement -- Verify correct font, font-size, leading -- Verify grammar is correct for generated text -- Verify no text (or fragment) is repeated on a page -- Verify padding around border of rectangle -- Verify no more than 5 poems appear on a given page

... other things?

[Real-John-Cheung]

Maybe also this two? -- Verify that custom fliters works (replace, not hide) -- Verify that temporary replacement (the strike button on the pop up page) works

[dhowe]

• [ ] Verify all tests pages (with ads) show at least one poem replacement
• [ ] Verify correct font, font-size, leading
• [ ] Verify grammar is correct for generated text
• [ ] Verify no text (or fragment) is repeated on a page
• [ ] Verify padding around border of rectangle
• [ ] Verify no more than 5 poems appear on a given page/visible at once
• [ ] Verify that custom fliters works (replace, not hide)
• [ ] Verify that temporary replacement (the strike button on the popup page) works

[Real-John-Cheung]

Time: 18/9/21 Platform: Win64&mac OS 10.15 Firefox 92.0

• [x] Verify all tests pages (with ads) show at least one poem replacement
• [x] Verify correct font, font-size, leading
• [x] Verify grammar is correct for generated text [ok]
• [x] Verify no text (or fragment) is repeated on a page
• [x] Verify padding around border of rectangle
• [ ] Verify no more than 5 poems visible at once - on hold
• [x] Verify that custom filters works (replace, not hide)
• [x] Verify that temporary replacement (the strike button on the popup page) works

Platform: Win64&mac OS 10.15 Chrome 93.0.

• [x] Verify all tests pages (with ads) show at least one poem replacement
• [x] Verify correct font, font-size, leading
• [x] Verify grammar is correct for generated text [ok]
• [x] Verify no text (or fragment) is repeated on a page
• [x] Verify padding around border of rectangle
• [ ] Verify no more than 5 poems visible at once - on hold
• [ ] Verify that custom filters works (replace, not hide) - occasionally fails in chrome
• [x] Verify that temporary replacement (the strike button on the popup page) works

Noticeable things These two ads have the same background and are next to each other...

[dhowe]

I will check grammar more closely later, so I've marked it as done

• [ ] Verify that custom filters works (replace, not hide) - occasionally fails in chrome

can you give an example?

These two ads have the same background and are next to each other...

Ideally we would never have two ads directly adjacent, but not critical for launch (if not very easy, create new post-launch ticket)

[Real-John-Cheung]

Verify that custom filters works (replace, not hide) - occasionally fails in chrome can you give an example?

It happens sometime when using the "replace this element" option from the right-click menu. An example is to replace the Yahoo logo on https://hk.yahoo.com

Will create tickets for both the problems

[dhowe]

And what is the status on > Verify no more than 5 poems visible at once - on hold

Is your suggestion doable? If not (or it is difficult), then perhaps a per-page limit is enough for launch, as long as ads over the limit are still blocked (and just made invisible)

[Real-John-Cheung]

Is your suggestion doable? If not (or it is difficult), then perhaps a per-page limit is enough for launch, as long as ads over the limit are still blocked (and just made invisible)

I think it is doable, but not easy... I added a per-page limit in https://github.com/dhowe/AdLiPo/commit/f25c7f4d3b9b543bace75504ebd6737ed97030bb