search

dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance
GNU General Public License v3.0
4.61k stars 191 forks source link

"Failed" clicking/collecting on facebook #1328

Open A2-NieR opened 6 years ago

A2-NieR commented 6 years ago

Describe the issue

Somehow AN stopped working for me on facebook. It now seems to be stuck on 355 ads detected, but does not click them or detect new ones. AN works fine now on other sites like the top 15 most popular news websites, but seems to be "frozen" on facebook for me.

(Btw. is it normal for AN having no ads detected on youtube?)

Screenshot in which the issue can be seen

screen shot 2018-02-13 at 16 48 27

Your settings

A2-NieR commented 6 years ago

Quick update: I got rid of the addon RandomUA and instead installed Canvas Fingerprint Defender. Now it seems to at least detect new ads again. It also clicks every ad but a few like the "l.facebook.com" ones.

screen shot 2018-02-14 at 23 52 13

screen shot 2018-02-15 at 22 32 13

cqx931 commented 6 years ago

Youtube: As most of the ads from youtube are video ads, adnauseam does help you to block them, but there is no image ad to collect. The number we are showing in the menu is actually the number of ads we collected.

@dhowe Maybe we should change that text to "XX Ads collected" to be less confusing?

dhowe commented 6 years ago

Yes, that makes sense to me, @cqx931. But pls check that the added width doesn't mess up the display on any platforms...

A2-NieR commented 6 years ago

Okay, due to switching back to firefox (from waterfox), I tested a couple of settings in about:config from privacytools.io and here is what I found:

privacy.resistFingerprinting = true (This one seems to cause the layout issues)

browser.cache.offline.enable = false (This one shows the wrong (all) numbers of ads detected)

Hope that helps.

dhowe commented 6 years ago

@cqx931 can we test these settings (especially the 2nd) to see how they are affecting the code ?

cqx931 commented 6 years ago

Thank you for the feedbacks! @BunnyTheLifeguard I just verified that privacy.resistFingerprinting = true does influence the layout in menu.

However I can't verify the second setting. I tested it with both image ads and text ads(with only adnauseam installed) and the number seems quite correct to me.

Could you please show us an example of the wrong number?(only adnauseam installed, empty the gallery beforehand, which site, the number you see from adnauseam menu, the number you are expecting to see)

Firefox version: 59.0b7

cqx931 commented 6 years ago

The layout issue is fixed here: https://github.com/dhowe/AdNauseam/pull/1332

A2-NieR commented 6 years ago

@cqx931 You were right, the second setting was not causing the bug. After playing around with it again it's working fine with the only exception being facebook, but there it just happens when the newsfeed is set to "Most Recent", newsfeed set to "Top Stories" is working fine for now.

Here is a screenshot for the "Most Recent" setting:

screen shot 2018-02-23 at 20 42 38

A2-NieR commented 6 years ago

Okay, since today it also works again with "Most Recent"… I'm confused. 😵