search

dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance
GNU General Public License v3.0
4.53k stars 189 forks source link

Ads not collected in some sites #1415

Closed DamjanMenton closed 1 year ago

DamjanMenton commented 5 years ago

Describe the issue

Hello everyone, I noticed that some ads were blocked, but not collected on multiple websites.

An exemple :

On e-hentai.org there are two ad banner on the top of the page. With the normal lists, they are displayed (on ublock, they are blocked). When I had the AdGuard Base filters, the ads are blocked, but they don't show in the Adnauseam icon.

Screenshot in which the issue can be seen

000009-window You can see in the top right corner that Adnauseam doesn't click nor collect ad.

Steps for anyone to reproduce the issue

(Please be as detailed as possible)

  1. Use the default filter settings
  2. Go on the website
  3. The ad is visible
  4. Add the Adguard Base filters
  5. Reload page
  6. The ads are not visible and not collected

Your settings

Your filter lists

Default lists + Adguard Base

Your location/country

Not country related

DamjanMenton commented 5 years ago

Some more informations : I tested with the latest Firefox (stable, not nightly) in a new virtual machine, the issue is still here. There are lots of other sites of the same type that has this collecting problem.

Thanks,

dhowe commented 5 years ago

@DamjanMenton, can you list the other sites as well?

@cqx931 I notice 3 problems on this site:

  1. Ads are visible with default lists (blocked in ublock)
  2. Ads are not collected when hidden/blocked via 'Adguard Base' list

  3. Right-click 'block element' menu doesn't work (see #1420)

    @cqx931 Can you take a look (post-exhibit) ?

DamjanMenton commented 5 years ago

Of course ! There is a lot of websites that still has ads visible (with the same problem). Here are some exemples :

Sorry, I did not put direct link due to the nature of most of theses websites, but I think you'll understand.

Most of these ads seems to have trafficjunky and juicyads as ad provider.

I also have a lot of ad popup for games or malwares (fake download, etc.). But it might be another bug, I don't really know. Exemple below : 000010-window

dhowe commented 5 years ago

Thanks for this. What would be great for us to know is which of these have ads visible with uBlock Origin (and not AdNauseam) enabled?

DamjanMenton commented 5 years ago

uBlock Origin seems to block all of them. I can't say precisely, my second computer that I use for tests like this has special network rules, it might be this who blocks the ads. However, I'm looking at the filters list of uBlock and it seems that these ads are listed in the main uBlock list.

Update : I just tried on my phone with the uBlock Origin extension, lots of ads are blocked (14 on the PH player for exemple, againt 0 with AdNauseam) when I go on theses sites, and no one pass through the uBlock filtering. Thanks for your work,

dhowe commented 5 years ago

The Adnauseam counter works a bit differently than the uBlock one does: our counter is only for ads that are actually collected, not those that are blocked or hidden (as is the case with uBlock). So AdNauseam may well be blocking/hiding ads on those pages, but the counter would still read 0 until one is successfully collected. The ideal way to test such things is to install AdNauseam and uBlock on the same computer (this doesn't cause any problems), then just enable one at a time and compare (though of course we understand if you don't have the time)

DamjanMenton commented 5 years ago

I doubted that the counter worked differently as it sometimes hide ads but don't shows as many numbers as uBlock. Thanks for the explanation.

So I installed uBlock Origin on the same computer and deactivated Adnauseam : all the sites I listed above don't show ANY ads anymore, uBlock is correctly blocking them.

dhowe commented 5 years ago

Thanks, we will look into these. Please keep adding to the list above if you find any other sites with visible ads (that are correctly blocked by uBlock)

Dyras commented 5 years ago

Flashback has ads that are successfully blocked with AdNauseam, but they aren't collected or clicked. Every ad on the site starts with flashback.org/ads/ so it should be easy to fix... Probably.

https://www.flashback.org/

Here are some pics of the ads: image image

cqx931 commented 5 years ago

@KenLiHK, could you please check https://www.flashback.org/? Thanks!

KenLiHK commented 5 years ago

2 yellow log messages found

.adcontainer

.ad-disclaimer

.ad-disclaimer is found in the "EasyList" -- "General advert blocking filters".

When ads is blocked, ADN cannot collect it.

image

Your settings

Your filter lists

AdNauseam filters​​​​ EasyList​​​​​ EasyPrivacy​​​​​ uBlock filters​​​​​

uBlock filters – Badware risks​​​​​ uBlock filters – Privacy uBlock filters – Resource abuse​​​​​ uBlock filters – Unbreak​​​​​ My filters​​​​​

Malware Domain List​​​​​ Malware domains

Your location/country

Hong Kong

metapea commented 5 years ago

There's a another adult site called hitomi .la that still show ads and give you pop-up ad if you click anywhere in the site, these are the site that they to redirect to:

Also uploading sites like: 1fichier.com is still showing ads and it's not letting me download unlike before, mediafire is still showing ads from adchoices, zippyshare is sometimes giving me pop-up ads when i click download, and with youtube/soundcloud downloaders like vubey.yt and flvto.biz/mp3-320kbps there usually pop-up ads when you click the download/save as button when you first click or when you click on convert like ytmp3.eu Edit: and tumbex.com does have pop up ads when you click on a tag, page or image. Edit 2: i also forgot about modsbase.com, where if you click on download, you will get a pop-up ad as well when you first click it.

dhowe commented 5 years ago

Thank you for the report. Have you checked that these ads are correctly hidden using uBlock Origin?

metapea commented 5 years ago

I'm just testing this with the AdNauseam alone, these pop up when using the latest version, and i'm really not in the mood to test them again, since some of the ads have mess with my browser before. Mostly this is just what i came across when browsing with AdNauseam.

mneunomne commented 2 years ago

@dhowe should we perhaps close this? There are multiple cases documented here which is useful, but also outdated at the moment.

Dyras commented 2 years ago

I'd say this is is still an issue with a lot of sites. For example, three major Swedish news sites all have this problem: https://www.aftonbladet.se/ https://www.dn.se/ https://www.expressen.se/

Edit: And just to clarify, it's blocking the ads as intended. But they aren't being clicked or collected.

Left is Firefox with AdNauseam, right is Chrome in Guest Mode without any extensions grafik grafik grafik

DamjanMenton commented 2 years ago

I can confirm that there are still a lot of websites were ads are not blocked/collected. I stopped using AdNauseam since last week to use uBlock Origin instead, that is lot more efficient against ads.

Dyras commented 2 years ago

I've never had any real issues with ads not being blocked. They are rarely collected and clicked though. Which is a pity, as that's the entire point of the addon.

Personally, I still have fate that they will sort this out. I think it's an amazing idea and I hope one day that they will make it work as intended :)

mneunomne commented 2 years ago

Thank you for the feedback, we try to keep the balance between ad collection and ad blocking, unfortunately there is no universal solution for what we propose to do, and as your comments themselves show, is that there is also significant differences of behaviour depending on your location and types of website you may visit.

https://www.aftonbladet.se/ https://www.dn.se/ https://www.expressen.se/

Thank you @Dyras, I will take a look on these cases specifically.

mneunomne commented 1 year ago

Addressed the remaining websites I mentioned above. Closing