dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance
GNU General Public License v3.0
4.53k stars 190 forks source link

Site does not load #1430

Closed mqus closed 1 year ago

mqus commented 5 years ago

Describe the issue

I'm reading my news on a german IT website - https://www.golem.de . They have also a ordered view of all their news: https://www.golem.de/ticker/ . This page will not load If AdNauseam is enabled. Curiously It is the only page on this site that does not work.

One or more specific URLs where the issue occurs

https://www.golem.de/ticker/

Screenshot in which the issue can be seen

Steps for anyone to reproduce the issue

(Please be as detailed as possible)

  1. In Firefox 63.0.3, disable all addons but AdNauseam.
  2. Try to open page https://www.golem.de/ticker/
  3. Page will try to load but fail after a timeout. 3.1 The Network Tool says that It has resolved the DNS, connected to the server and began the transfer from the server to my browser. It stopped after ~33kb of ~100kb for no reason (console is empty) and still loads (spinning circle on the tab logo)
  4. Disable AdNauseam -> Page loads as usual.

Your settings

Your filter lists

Essentials w/o Annoyances and Resource Abuse

+Malware Domain List +Malware Domains +DEU

Your location/country

(If the issue is website specific, knowing your approximate location will help us to reproduce it) Germany

dhowe commented 5 years ago

Confirmed. Not sure what is causing this as the logs show no blocks. @cqx931 can you take a look?

image

cqx931 commented 5 years ago

I can't reproduce with FIrefox 64.0b8 on my mac. @dhowe have you made any special change in the settings to reproduce it?

dhowe commented 5 years ago

No, I just see a blank page with normal settings. If you look at the networks requests, you will see that only the root page and the favicon are requested. When ADN is off, however, many other scripts are requested as well...

image

cqx931 commented 5 years ago

@KenLiHK Can you reproduce this ticket?

KenLiHK commented 5 years ago

I cannot reproduce this case.

Please refer to the following screen captures.

screen1

screen2

Your settings OS/version: Windows 10 Enterprise Browser/version: Firefox 63.0.3 (64-bit) AdNauseam version: AdNauseam3.7.802 Other extensions you have installed: N/A

Your location/country Hong Kong

dhowe commented 5 years ago

Have you tried with a German proxy or VPN?

KenLiHK commented 5 years ago

I cannot reproduce the case when German proxy is turned on.

1430

mqus commented 5 years ago

I just want to mention that the bug still persists (I have now installed firefox 64.0.2, AN 3.7.802).

Just to mention: Since then I also changed my internet provider (unrelated to this issue, from telefonica to dt. telekom) so this is not due to a specific provider messing with stuff.

dhowe commented 5 years ago

Ok, I have confirmed this now.

It appears to be caused by filters in the 'uBlock filters' list. We can verify this by turning this list off in settings->3rd-party-filters and noticing that the page reappears.

Specifically 3 cosmetic filter rules are triggered:

image

all from 'uBlock filters:

image

The strange thing is that the following rules are fired with uBlock (where the page does show):

image

Note the two differences, first the different syntax of the rules (with +js instead of script-inject), and second, the fourth rule for uBlock (using shadowroot) .

"script-inject" has apparently been changed to +js on Sep 7, 2018

I tried this same comparison with the version of uBlock (v1.15.24) on which the current version of AdNauseam is built, and, perhaps interestingly, the uBlock filters list cannot be updated, which may be due to this release note:

image

Thus I cannot test the current 'ublock filters' list in this (older) addon version...

I also notice that toggling 'disable cosmetic filters for this site' does NOT fix the problem, as I think it should...

image

I also find this note in adn/dnt.js:

image

which leads me to believe that this is a problem in adn code (the function is found nowhere else in the project)

In any case, I'm not sure how to proceed here besides testing a new adn build (atop a new ublock base) -- @cqx931, your thoughts?

dhowe commented 5 years ago

@cqx931 status on this?

cqx931 commented 5 years ago

Just tested this on the new release. I couldn't reproduce this issue before and now everything still seems okay to me on this website.

AdNauseam does have the +js cosmetic filters triggered by now. Not sure if that's going to fix the issue. image

mneunomne commented 1 year ago

Site is working fine, issue seems to be outdated, closing now.