search

dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance
GNU General Public License v3.0
4.59k stars 191 forks source link

Google ads visible on spiegel #1491

Closed dhowe closed 1 year ago

dhowe commented 5 years ago

All articles, an example:

https://www.spiegel.de/international/germany/german-failure-on-the-road-to-a-renewable-future-a-1266586.html

image

cqx931 commented 5 years ago

Could we think out a better strategy to deal with "generichide"? As more and more sites are trying to detect adblockers, it's not very effective to write hiding rules one by one to all of these sites. Something like adding basic generic hiding rules to that specific domain if a generichide filter is detected?

For spiegel.de for example, we need a site specific google ads rule such asspiegel.de##[id^="google_ads_iframe_"] to hide most of the google ads.

Similar cases we have solved in the past: https://github.com/dhowe/AdNauseam/issues/1476 https://github.com/dhowe/AdNauseam/issues/1480

metapea commented 5 years ago

also so with the basic filters (version 3.8.101) in places like chan.sankakucomplex.com (nsfw) and booru.org (with ads2.contentabc.com poping up now) being unblocked, and are now showing ads unlike the last version were everything was fine in those sites. Edit: cultistsimulator.gamepedia.com is showing ads as well and with spam404 the site broke down after a long time with multiple of tabs

cqx931 commented 5 years ago

@metapea Could you please create separate tickets for the issues you mentioned above? Please also try to fill in as much as possible in the ticket template(especially the url and the browser you are using), so that it will be easier for us to reproduce the issue. I have tried the three sites you mentioned on chrome with version 3.8.101 and I can't reproduce the ads. Thanks!

dhowe commented 3 years ago

Also cannot reproduce on Spiegel. Please check the others mentioned:

metapea commented 3 years ago

cultistsimulator.gamepedia.com seems to be fine now chan.sankakucomplex.com & booru.org, i'm not sure with the default filters since i'm already using block element and custom filters

gelbooru & others sites does a problem with ''exo_wrapper" which is a semi-popup ad and you can't use block element to remove it. The latest version of uBlock does block it at least.

dhowe commented 3 years ago

i'm not sure with the default filters since i'm already using block element and custom filters

we generally use the default filters for testing -- via a separate FF and/or Chrome profile for this

gelbooru & others sites does a problem with ''exo_wrapper" which is a semi-popup ad and you can't use block element to remove it. The latest version of uBlock does block it at least.

what rules fires in ublock to block these?

metapea commented 3 years ago

what rules fires in ublock to block these?

What i mean is, uBlock blocks it by the default filters unlike nauseam. I haven't been looking into it, just something i've notice when i used the latest version of uBlock.

we need to use the default filters for testing

Alright i already know, just letting you know about the block element and custom filters since it's has been close to 2 years when i posted that Maybe i will test it some time later.

dhowe commented 3 years ago

thanks @metapea!

mneunomne commented 1 year ago

Seems like this issue is now outdated, ads are being correctly hidden on Spiegel. Closing for now.