dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance
GNU General Public License v3.0
4.54k stars 190 forks source link

AdNauseam and Brave #1701

Open cqx931 opened 4 years ago

cqx931 commented 4 years ago

Text ads from search engines are okay, but image ads are stopped by Brave's native ad blocking mechanism

Screenshot 2020-07-24 at 3 46 08 PM

They are using Ad Block engine in Rust

cqx931 commented 4 years ago

For ad collection/clicking to work, users need to go to brave://settings/shields and disable "Trackers & ads blocking"

cqx931 commented 4 years ago

We can't know users brave settings using extension API, but we can add a warning message for brave users and a corresponding FAQ entry if we can verify in the content script that common ads(google ads) have been blocked.

cqx931 commented 4 years ago

@dhowe

dhowe commented 4 years ago

So the content-script notices that common ads are blocked and sends a message to the core which triggers the extension warning ? How to recognize that a common ad is blocked ?

cqx931 commented 4 years ago

Brave also block ads mostly by blocking web requests. If a user uses Brave and on initial install, we could potentially test it using one of our example pages. If adnauseam can't collect any ads from this page(or a dedicated test script to check whether iframes are fully rendered or not) while other potential reasons are eliminated, we can show a warning message related to Brave's native ad blocking.

Screenshot 2020-08-18 at 11 27 11 AM

But I don't think this should be tested on every page, that would be too much work in vain.

danielplatt commented 3 years ago

How do I install AdNauseam for Brave? When dragging the .crx file into my browser it is automatically disabled and I see no way to enable it.

dhowe commented 3 years ago

@mneunomne pls test

mneunomne commented 3 years ago

Yes, that is indeed happening, can't turn the extension on. Not sure how it worked before, but apparently Brave is not allowing ads that are not from the store anymore:

Extensions that have not been published on the Chrome or Brave Web Store are grayed out and you won't be able to turn them back on.

https://support.brave.com/hc/en-us/articles/360017914832-Why-am-I-seeing-the-message-extensions-disabled-by-Brave-?hl=en-GB

Screen Shot 2021-02-28 at 12 42 59

dhowe commented 3 years ago

The conclusion here appears to be that Brave no longer allows extensions from outside the Google Chrome store

Here is some discussion about it: https://github.com/brave/brave-browser/issues/2457, containing a link to the relevant Brave policy: https://support.brave.com/hc/en-us/articles/360017914832-Why-am-I-seeing-the-message-extensions-disabled-by-Brave-?hl=en-US

divad42 commented 3 years ago

I was able to install AdNauseam on Brave from the unpacked zip on both Linux and Windows

dhowe commented 3 years ago

Excellent. @divad42 If you can you include the steps to get them both installed, we can add to our wiki...

@mneunomne we also need to add an FAQ entry (and possible a warning) re: Brave's ad blocking mechanism as described above by @cqx931

bonecountysheriff commented 3 years ago

The chromium zip works on linux, the .crx file doesn't (extension cannot be enabled).

dhowe commented 3 years ago

@mneunomne can you update our page with instructions for installing Brave here: https://github.com/dhowe/AdNauseam/wiki/Install-AdNauseam-on-Chrome-Without-Google's-Permission

caseysoftware commented 3 years ago

On Brave (v1.22.71 on Mac), the quick fix:

Yes, this is the same as Chrome right now.

dhowe commented 3 years ago

@mneunomne sounds as if we can treat brave just like chrome -- pls update docs (lets also add a note in post-release testing to check the following suspicion from @caseysoftware):

Brave may disable AdNauseam on upgrade. I've seen that with other no longer supported extensions.

We also need to add a FAQ entry (and possible a warning) re: Brave's ad blocking mechanism as described above by @cqx931

dhowe commented 3 years ago

status @mneunomne ?

mneunomne commented 1 year ago

Sorry @dhowe somehow I missed the latests updates on this issue entirely.

It seems that yes, Brave as far as we are concerned, follows the same installation pattern than chrome. This information is already present in our documentation.

Regarding the image ads blocking, seems that they are being collected collected in general at a lesser level. For them to be collected normally, the user needs to change to "allow trackers and ads" configuration:

Screenshot 2023-02-21 at 02 44 32
mneunomne commented 1 year ago

Added this info on Brave installation segment on chromium installation wiki:

https://github.com/dhowe/AdNauseam/wiki/Install-AdNauseam-on-Chromium-based-browsers#optimal-configuration-for-ad-collection-on-brave