search

dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance
GNU General Public License v3.0
4.51k stars 189 forks source link

Cannot click javascript links on pages where ads are blocked #1730

Closed McBobb closed 3 years ago

McBobb commented 3 years ago

Describe the issue

While this has only occurred on the domain, "forum2go.nl", it happens on every site there. Any time there is a link that is identified as Javascript, I cannot click it at all while AdNauseum is activated. Once I deactivate AdNauseum and relaunch my browser (Firefox 80.0.1), I'm able to click the previously inactive link. There is no warning message or flag of any time; just nothing happens

Screenshot in which the issue can be seen

Steps for anyone to reproduce the issue

(Please be as detailed as possible) Simply have AdNauseum active when visiting any page on the "forum2go.nl" domain that has [JavaScript] links, instead of regular URL links, and they will be inactive.

Your settings

Your filter lists

Default

Your location/country

(If the issue is website specific, knowing your approximate location will help us to reproduce it) Canada (EST)

** For adult and potential offensive sites/advertisements, please add a [Content Warning] tag in the title to warn developers that there may be offfensive material in the ticket.

mneunomne commented 3 years ago

I tried to reproduce this issue but I visited multiple websites with this domain and all links seemed to be working fine, would perhaps need a more specific example of the exact page where this issue can be observed.

However, navigating a webpage within this domain I experienced another issue which might be related to the googleads not being removed properly:

Screen Shot 2021-02-16 at 15 28 01

there is still an element with the class adsbygoogle without content inside of it, but it is still hovering over the page and blocking the clicks under them.

mneunomne commented 3 years ago

Plus, I realised this is a AdNauseam specific problem, with uBlockOrigin the ads disappear without blocking the clicks.

Screen Shot 2021-02-16 at 16 08 28 Screen Shot 2021-02-16 at 16 07 34

dhowe commented 3 years ago

It seems like some part of the google ad is not being properly removed from the dom... (and is thus blocking things behind it). The first thing to try is adding a rule in AdNauseam's Settings/My-Filters to fully hide that element. You can add it manually and test, or perhaps try with the element-blocker in the context menu (right-click, "block-element")

mneunomne commented 3 years ago

Fixed with this PR

added a domain specific rule for "forum2go.nl":

forum2go.nl##.adsbygoogle

There seemed to be an issue where the ##.adsbygoogle rule from Easy-List was being overruled by the Adn rule ##ins[id*="aswift"] > iframe, causing the upper .adsbygoogle element not being properly hidden. We should see if the same issue happens on other domains and try to come up with a more non-domain-specific solution.