Update design for menu to clarify and support strict-blocking

[dhowe]

Need to support the following in the bottom section of the menu (*indicates a new item):

• strict-block-site *
• disable-on-site
• disable-on-page
• ublock settings
• settings (perhaps switch to gear icon?)
• faq

There is also the potential concern that the current 'disable' button suggests disabling ADN altogether, rather than only for the current page/site

[mneunomne]

@mushon Any idea how are we going to deal with other languages (and likely longer texts) the space is a bit tight so I imagine it will overflow

[mushon]

In the toggle?

I prefer not but we could go for a smaller font size if need be.

[mneunomne]

@dhowe what are the main languages that are used with adnauseam ? The toggle buttons indeed might become an issue since the space is already quite tight with english...

[dhowe]

not sure -- here's the full list: https://crowdin.com/project/adnauseam

[mneunomne]

not sure -- here's the full list: https://crowdin.com/project/adnauseam

I mean the most often used. English, Russian, Chinese, German... Another one that we should definetelly test? Just to make sure that the UI doesnt get very broken

[mneunomne]

@dhowe I implemented new footer menu with mostly working interactions (not implemented the "On this page" / "domain" differences):

Some things that we need to think about:

• Implement some sort of notification or status when Strict is enabled (and maybe linking to the strictBlockList page)
• Perhaps remove the "DISABLE - EVERYWHERE" functionality, it does not exist in uBlock and it would require some other not-implented mechanism.

[dhowe]

Perhaps remove the "DISABLE - EVERYWHERE" functionality, it does not exist in uBlock and it would require some other not-implemented mechanism.

agreed - the browser already provides this function for all addons

Implement some sort of notification or status when Strict is enabled (and maybe linking to the strictBlockList page)

also probably need a new color for the adn icon (we already use purple=normal, red=disabled, green=dnt)

[mneunomne]

@mushon @dhowe I think for the strict state this type (no ads collected) of menu alert should be implemented? Perhaps better than the usual "warning"

[dhowe]

that is an alert for when there are no ads FOUND on the page (either there are none, or we couldn't parse any) we could change the text to read 'in strict mode', or we could do something similar to below, also with updated text also need a new color for the icon

[mneunomne]

@dhowe @mushon I wonder if it should be this alert instead, since some ads can still be collected even if Strict Blocked mode is enabled.

Maybe with a different type of alert image.

[dhowe]

That works for me (though the css should match the other alerts) I think we also need a link (perhaps to the "strict-blocked" text) to the FAQ entry And strict-blocked should probably be lower-case...

[mneunomne]

That works for me (though the css should match the other alerts) I think we also need a link (perhaps to the "strict-blocked" text) to the FAQ entry And strict-blocked should probably be lower-case...

Will do

[mneunomne]

Implemented the alert when 'strict' is on:

Added a short text in the 'strict block list' page:

The strict block list serves to help the users to strict block specific domains or pages more easily. link

@dhowe any final comments?

[dhowe]

again, strict block is only for domains, correct?

[mneunomne]

Yes. But the user can still make a page-based strict-block directly in the "Strict Block List".

[dhowe]

yes, but it doesn't make it 'more easy' to do...

[dhowe]

@dhowe any final comments?

Let's add a dash between 'strict' and 'blocked', but otherwise looks good to me, @mushon?

[mneunomne]

@dhowe I suggest a super minor change, that is kind of trickying me up a bit:

Keep the uBlock button on the same side as before. My muscle memory is making me click the wrong button all the time, and I guess for other long time users this change of position might be a little irritation.

Super minor, but perhaps valid.

[dhowe]

ok for me, @mushon ?

[mushon]

Sure thing..

Mushon Zer-Aviv

Recent work: Normalizi.ng Mushon.com | Shual.com | @Mushon

On 29 April 2022 at 12:03:52, Daniel Howe @.***) wrote:

ok for me, @mushon ?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

[mneunomne]

Great work! As we already have implemented i'll be closing this issue