search

dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance
GNU General Public License v3.0
4.52k stars 189 forks source link

Click on Ads that can't be collected? #2232

Closed mneunomne closed 1 year ago

mneunomne commented 1 year ago

At the moment we don't click on many ads because we cannot collect them, such as Video ads and Ads that are constructed with HTML structures, svg sequences etc. I was wondering if we could perhaps click on ads that we only have the link available?

Also we currently only collect (and therefore click) on ads that we can collect all the necessary information (title, description, img{in case of img ads}). Perhaps we can make this a bit more flexible so we can click on more ads.

What do you think @dhowe?

dhowe commented 1 year ago

Yes, this makes sense. We just need to figure out how we handle the counts and what we show in the menu and vault for such ads

mneunomne commented 1 year ago

Actually, managed to go around this issue regarding videos because now we are collecting poster images from <video> tags. https://github.com/dhowe/AdNauseam/issues/2234

I would say we don't need to address the other types mentioned above, at least for now. We can close and maybe come back if we think it's really necessary to click on non-collectable ads.