search

dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance
GNU General Public License v3.0
4.58k stars 191 forks source link

bug with procedural filters on pinterest.com #2235

Closed mneunomne closed 1 year ago

mneunomne commented 1 year ago

It seems that there is some issue with the way that I implemented ad collection on top of the cosmetic procedural filters system.

when attempting to apply the current procedural filter on pintenrest.com for ad collection purpuses, the page breaks, which doesn't happen in uBlock:

pinterest.com##.zI7.iyn.Hsu:has(video[poster^="http"])

I didn't detect this issue in other pages, but since the [ADN] proceduralFiltererInstance null warning keeps showing up for unknown reason, it is best to understand what is causing it.

If I can't find a way to fix this, we could add the option of enable Ad collection with procedural only optionally, but thats not ideal.

Reference for what are procedural filters: https://github.com/gorhill/uBlock/wiki/Procedural-cosmetic-filters

mneunomne commented 1 year ago

Actually adding :scope to the procedural filter as suggested uBlock in the documentation made it work:

pinterest.com##.zI7.iyn.Hsu:has(:scope video[poster^="http"])

But still seems that there is an underlying issue with the implementation of ad collection on the procedural filters.

mneunomne commented 1 year ago

Created a separate ticket for the procedural filter overall here: https://github.com/dhowe/AdNauseam/issues/2244

Closing this one since it was solved within the scope of this particular filter.