dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance
GNU General Public License v3.0
4.52k stars 189 forks source link

confusing information on 'trusted pages' tab. #2239

Open slyfox1186 opened 1 year ago

slyfox1186 commented 1 year ago

Describe the issue

This YouTube video should explain a lot.

Your settings

Your filter lists

All of them + Russian language

Your location/country

Atlanta, GA USA

** For adult or potentially offensive sites/ads, please add a [Content-Warning] tag in the title to warn developers the ticket may contain such material.

N/A

mneunomne commented 1 year ago

hey @slyfox1186 thanks for submiting the ticket. Maybe the issue is that we didn't message this correctly.

The link that you have clicked is actually the exception list that adnauseam works with. The whitelist bellow is an additional list of websites that you can add yourself. for example if you want to add "nytimes.com" in the whitelist, you simply add as:

nytimes.com
washingtonpost.com
! etc...

the list that you tried to add in the video was the exception list that is already enabled by default. If you try to access any of the websites in that list, you'll see that adnauseam icon turns green, meaning it is allowing the ads on that webpage depending on the configurations on your initial page:

Screenshot 2022-12-21 at 02 37 16

So if you want to disable this initial EFF whitelist, you should uncheck the two checkboxes above.

If you want to add aditional websites, simply add it to the whitelist following the uBlock Origin guide:

https://github.com/gorhill/uBlock/wiki/How-to-mark-a-web-site-as-trusted

Hope this answers your doubt. Otherwise let us know what you need and we I can give a more precise solution. Either way this probably means we need to change how we phrase our whitelist page.

dhowe commented 1 year ago

closing for now - pls create a separate ticket for whitelist language if needed

mneunomne commented 1 year ago

I guess the issue is rather that the DNT EFF info maybe shouldn't be displayed in the whitelist section, but rather where the DNT options are. But not sure how to fit it there.

EFF DNT Policy Whitelist‎ (www.eff.org)

dhowe commented 1 year ago

@mneunomne can you explain? the DNT list is a whitelist, and it has its own section on the whitelist page to differentiate from user-supplied sites

But disabling that list should also (automatically) uncheck the two settings you refer to, no ?

mneunomne commented 1 year ago

All I am saying is that perhaps it is a bit confusing that the DNT whitelist is actually a filter list, and has a different syntax from whitelist.

Screen Shot 2022-12-28 at 12 43 52

Maybe it would make more sense for it to show up on the filter list on a DNT section? But maybe there is a reason why it isn't there.

dhowe commented 1 year ago

Yes, we can consider whether it should have its own page, or, as suggested by Mushon, replace it with GPC or similar.