search

dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance
GNU General Public License v3.0
4.52k stars 189 forks source link

Null Procedural Filter Instance #2244

Closed mneunomne closed 1 year ago

mneunomne commented 1 year ago

It seems that the implementation of the procedural filters is still causing some kind of underlying issue, need to address it.

Sometimes the proceduralFilterInstance is null while parsing the document.

Perhaps this is related to the following current issues: https://github.com/dhowe/AdNauseam/issues/2195 https://github.com/dhowe/AdNauseam/issues/2235

originally implemented with https://github.com/dhowe/AdNauseam/issues/2150

The issue is manifested in this function, which is used to get all the selectors to run the query on the document:

https://github.com/dhowe/AdNauseam/blob/3a56e11f4ad35ba1fb89a0c8a336b5c3912a1d80/src/js/contentscript.js#L654-L698

mneunomne commented 1 year ago

PR above fixes this exception, this check is not necessary anymore. Closing.