Menu breaks layout in languages other than english

dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance

GNU General Public License v3.0

4.52k stars 189 forks source link

Menu breaks layout in languages other than english #2246

Closed mneunomne closed 1 year ago

mneunomne commented 1 year ago

Screen Shot 2022-12-30 at 07 29 26

This was submitted as a review in firefox store, but can't reproduce it.

tiomny commented 1 year ago

mneunomne commented 1 year ago

Was not able to reproduce. closing for now.

tiomny commented 1 year ago

Was not able to reproduce. closing for now.

Steps to reproduce:

install additional language in browser. Words in that language should be spelled with more letters. French, Polish or Russian suits.
Select that language to display menus.
Restart browser.
Click on AdNauseam icon in toolbar.
See screenshot above.

mneunomne commented 1 year ago

@tiomny sorry, for some reason the image that you had previously posted didn't appear to me. Now I see, and yes of course, forgot to test those other languages with longer strings. Thank you for letting us know.

mneunomne commented 1 year ago

@tiomny In the PR above I fixed the breaking menu layout and also I added a fallback font for cyrilic characters:

mneunomne commented 1 year ago

tested in other languages (german, portuguese, french), seems fine now:

Captura de Tela 2023-02-21 às 14 52 58 Capture d’écran 2023-02-21 à 14 51 04 Bildschirmfoto 2023-02-21 um 14 50 35

mneunomne commented 1 year ago

(polish, arabic, hebrew all dont have translation for the menu button at this moment)

mneunomne commented 1 year ago

Fixed, closing.