dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance
GNU General Public License v3.0
4.51k stars 189 forks source link

Make lists on core.js editable by the user #2311

Closed mneunomne closed 1 year ago

mneunomne commented 1 year ago

The following lists on core.js are currently hard-coded:

which makes issues such as https://github.com/dhowe/AdNauseam/issues/2310 only fixable by making a new release. This should be able to controlled directly by the user by one of the options:

dhowe commented 1 year ago

tradeoff here is how often/likely/useful they are to be adjusted by user vs the implementation and maintenance cost

if we do implement, need to make sure these are hidden away from the typical user in some kind of advanced management tab...

mneunomne commented 1 year ago

Here in the advanced settings you have the option to have parameters as arrays as well:

Screen Shot 2023-03-05 at 15 41 02

mneunomne commented 1 year ago

I'll apply the case above for internalLinkDomains only. enabledBlockLists should be done in the 3p-filters tab with a checkbox somehow, as suggested here https://github.com/dhowe/AdNauseam/issues/1003

mneunomne commented 1 year ago

Implemented, closing