d3 wizard needed for advault

dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance

GNU General Public License v3.0

4.55k stars 190 forks source link

d3 wizard needed for advault #232

Open dhowe opened 8 years ago

dhowe commented 8 years ago

help us implement the many flavors of filtering we need in the advault

screen shot 2016-06-07 at 8 58 38 am

agaurav commented 7 years ago

What exactly is needed to be done for this for feature?

dhowe commented 7 years ago

The basic functionality is there, but the code is not pretty (so it could be tweaked or rewritten)...

The main problem with the current version are the date-filtering, which, as you can see above, doesn't always show the correct number of ads for a given date, and is a bit buggy. Also performance on larger ad collections is an issue.

First real improvement would be to add filtering on a number of ad properties: ad-type (text or image), ad-network, page-domain (more on this [here])(https://github.com/dhowe/AdNauseam/issues/115). The inspector (when you click on an ad) could be improved.

We also like to add new ads to the display, as they come in, rather than only on refresh.

agaurav commented 7 years ago

Ok, let me go through the code and think on what can be done. From what you said, I think using crossfilter with dc.js will be the right way to go from performance perspective & allowing efficient filtering.

dhowe commented 7 years ago

That would be great... I can also send you a JSON file for testing if that is helpful (or you can just use the addon for a little while and then do an 'export' from the vault or options page)

One thing to note is that ads in the vault are organized into AdSet objects, which is what you actually see in the primary vault interface; only when you click on an ad to inspect it do you see the individual ads themselves.

mushon commented 7 years ago

Hi @agaurav thanks for jumping in. Please note some light cosmetic changes we added in d7073a9 (mainly styling) Beyond @dhowe's notes about required changes:

[ ] there's a very basic bug where the y axis is not scaled to the number of ads and in fact the bars are masked into the chart's frame (rather than resized proportionately).
[ ] also, we would rather have the brush extent appear under the bars (and keep the handles above as is) and have a class on brushed bars so their colors can be differentiated.

Thanks for the willingness to jump in and play with it.

Pavel-Rossius commented 7 years ago

i know a bit. how can i help? can we connect? your tool is absolutely amazing!

dhowe commented 7 years ago

That would be great @PsY-VIRUZ (and thanks for the kind words)... The Ad data that gets displayed in the vault comes from a JSON file created by the addon. This data is used to create the circular layout that you see (the user can then click on an specific Ad to view its details). The view at the bottom shows the visible Ads by date and allows the user to select a date-range to view.

The code is pretty messy in general (and only the date-display is now in d3), so a full rewrite is probably in order at some point in the future. But what would be great in the short term is to to fix the date display at bottom so that it accurately represents the number of ads for each date (see https://github.com/dhowe/AdNauseam/issues/241).

To get a JSON file, you can use the 'export' button in either the vault or the settings page (or I can send you a test file to play with)

Pavel-Rossius commented 7 years ago

OK. I will contact You on a week :) need time to do main work :) probably, 2-3 days. have a nice time!

mushon commented 7 years ago

Thanks @PsY-VIRUZ, once you're set up feel free to ping me. I would happily support you design-wise.