search

dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance
GNU General Public License v3.0
4.46k stars 187 forks source link

merge to 1.46.0 #2320

Closed mneunomne closed 1 year ago

mneunomne commented 1 year ago

Merge to uBlock 1.48.0, current version is 1.49.2 as of today 27.04.2023.

mneunomne commented 1 year ago

This is quite annoying...

Code maintenance: replace uDom.js with dom.js uDom is old and crusty and dom is meant as replacement. The goal of dom is to be simpler and mainly just convenience methods for handling the DOM with vanilla JS -- this is not a framework. Additionally, removed keyboard shortcuts pane which was useful only on very old versions of Firefox.

https://github.com/gorhill/uBlock/commit/feaa338678ab64e334d33d5b5fb06749877454e7

we have over 200 entries with uDom in our code. to replace all entries will be complicated since there isn't a global replace, need to go careful case-by-case more or less.

Considering keeping uDom implemented instead within adnauseam scope.

mneunomne commented 1 year ago

in merge 1.46.0 I retained the uDom for the adnauseam files in order to keep it simple for now. We should slowly replace them with the new js/dom.js.

mneunomne commented 1 year ago

implemented

mneunomne commented 1 year ago

Merged, closing