dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance
GNU General Public License v3.0
4.6k stars 191 forks source link

Ads visible on Youtube #2385

Closed dhowe closed 1 year ago

dhowe commented 1 year ago

As reported via several email users...

RowanSkie commented 1 year ago

I believe it was earlier this week, not just today. I pushed my AdNauseam to the beta branch just earlier thinking it was just outdated.

When I run a YouTube video, I get the pre-video ad that automatically vanishes after a quick refresh.

EDIT: Using Brave Browser, by the way, with Brave Shields turned off for AdNauseam to run.

undeadcorvid commented 1 year ago

I came here to report the same issue - I can't see the ad, all I see is a black screen, but I can hear it, and all the usual YouTube ad UX pops up.

JCD3nt0n commented 1 year ago

Confirming that firefox 111.0.1 adnauseum 3.17.0 Black screen audio only, only the time skip buttons pop up for the first ad video and hitting skip button when unlocked terminates any all the remaining adds without playing the next. Changed profiles, reinstalled firefox, ditto for adnauseum and even double down on the blocklists.

BaconCatBug commented 1 year ago

Confirming that firefox 111.0.1 adnauseum 3.17.0 Black screen audio only, only the time skip buttons pop up for the first ad video and hitting skip button when unlocked terminates any all the remaining adds without playing the next. Changed profiles, reinstalled firefox, ditto for adnauseum and even double down on the blocklists.

Same issue here, no ad plays, but the ad wrapper does.

dhowe commented 1 year ago

see also: https://www.reddit.com/r/uBlockOrigin/comments/16lmeri/comment/k1uf2s1/ https://github.com/uBlockOrigin/uAssets/issues/7636 https://github.com/uBlockOrigin/uAssets/commit/a00326fcaa04883556a87e25e9d4b6d46b533435

can someone confirm whether this is also happening with ublock origin?

BaconCatBug commented 1 year ago

can someone confirm whether this is also happening with ublock origin?

It has not happened to me since I switched to uBlock Origin, but the whole you can't prove a negative thing, I'll post back if it does happen.

JCD3nt0n commented 1 year ago

can someone confirm whether this is also happening with ublock origin?

Further testing is required but apparently installed origin disabled adnauseum run a couple videos and nothing, disabled origin ran a couple of videos and got ads to play, re-enabled adnauseum and the behaviour stopped weird. Further testing required.

Edit: doubled down the behavior seems to have returned but it only appears on unskippable ads or double or more adrolls with adnauseum, ublock origin remains free of this bug.

Ozzy4201 commented 1 year ago

Confirmed with Adnauseam 3.17.0, chrome 117.0.5938.92

dhowe commented 1 year ago

I've committed a potential fix via our filter list. Would be great if people could re-test, as I cannot recreate the problem here:

  1. Go to Menu->Settings->Filter-lists
  2. Click the clock icon next to 'AdNauseam filters', then click 'Update Now' at top

image

Mouse-over the clock to see that it was updated...

Ozzy4201 commented 1 year ago

Didnt work the first time, but after trying about 50 other videos, it seems to have worked again. Will update if i get another ad.

Ozzy4201 commented 1 year ago

Yep. Midroll ad during a Veritaseum video, but seems much less common.

RowanSkie commented 1 year ago

Updated mine. It went from every video to every few videos. Brave Version 1.58.131 Chromium: 117.0.5938.92

JCD3nt0n commented 1 year ago

Confirming, happens less but every 13 videos or so I get the same behavior. Double ads still popping up, skipping first still kills the second. Also double down on with the purge button updating the entire thing and then using the same method as in bug report #2387 problem persists.

undeadcorvid commented 1 year ago

Still getting midroll ads, yep. And like JCD3nt0n said, you do at least kill the second ad by skipping the first.

Purging and updating does not help. I'm on Firefox 117.0.1 (64-bit)

Edit: Not just midroll ads, I just mercifully didn't get a beginning-of-video ad before.

U2C9727A4 commented 1 year ago

Confirming that firefox 111.0.1 adnauseum 3.17.0 Black screen audio only, only the time skip buttons pop up for the first ad video and hitting skip button when unlocked terminates any all the remaining adds without playing the next. Changed profiles, reinstalled firefox, ditto for adnauseum and even double down on the blocklists.

I am getting the exact same issue. An ad with sound but no video. Theres also the skip ad button which makes me wait for 5 seconds. However ive been able to observe this issue in private tabs. Some of the newer youtube features is not given to my google acccount instantly but it is given to private tabs. Youtube might be trying out some ads that can bypass adblockers maybe, would require further investigation.

UphillSky commented 1 year ago

Can confirm this is happening on my end with the latest firefox, no video but audio still present

UphillSky commented 1 year ago

Curiosly, clicking the update does not appear to update my filters, now that I try

blazingwinter commented 1 year ago

Same issues for me on Chrome, thought it was me just being lazy and not having updated this in awhile. About every other video or so will have ads on them. Refreshing will skip the beginning of video ad, but midroll ads still happen. I'm rarely ever getting the option for skipping any of them, especially annoying with double or triple ads. Filter update didn't help on my end, I did see that the number changed, but nothing happened.

mneunomne commented 1 year ago

Can also confirm this issue. But now after update I'm having a hard time reproducing it again. Trying to understand what is causing it since the filters are indeed updated with uBlock and there are no adn-allowed rules going through with strict-block turned on.

mneunomne commented 1 year ago

Most probable cause of this is the fact that our codebase is behind uBlock Origin's, and the scriptlets and procedural filters are not up-to-date with the filters present in the uAssets filter list. Will try to merge up to 1.50 as quickly as possible to address this issue.

https://github.com/dhowe/AdNauseam/issues/2390

RowanSkie commented 1 year ago

Okay, it took only a few hours but now it's back to almost every video that has ads.

adlion commented 1 year ago

I have a similar behavior. On youtube the ads are black screen, the skip ad button is shown and even after refreshing filters list or purging and re-downloading the issue is still there.

I am on ubuntu 22.0 LTS with Firefox 117.0.1-2

U2C9727A4 commented 1 year ago

Confirming that firefox 111.0.1 adnauseum 3.17.0 Black screen audio only, only the time skip buttons pop up for the first ad video and hitting skip button when unlocked terminates any all the remaining adds without playing the next. Changed profiles, reinstalled firefox, ditto for adnauseum and even double down on the blocklists.

I am getting the exact same issue. An ad with sound but no video. Theres also the skip ad button which makes me wait for 5 seconds. However ive been able to observe this issue in private tabs. Some of the newer youtube features is not given to my google acccount instantly but it is given to private tabs. Youtube might be trying out some ads that can bypass adblockers maybe, would require further investigation.

CONFIRMED Ive been starting to see ads on regular youtube aswell. Youtube might be trying to implement stuff to bypass adblockers.

mneunomne commented 1 year ago

I just made a new pre-release which is merged to uBlock Origin's latest version 1.52.2, and it seems that the ads are not showing anymore, but requires more testing. Would be nice if you could also submit other possible issues with the application since I had to do these merges quite fast since this was an emergency with the ads showing.

https://github.com/dhowe/AdNauseam/releases/tag/v3.17.9b1

Let me know if the ads on youtube persist, and make sure the filter lists are updated.

(maybe its a good idea to install it on a separate browser profile, since this is a beta release)

U2C9727A4 commented 1 year ago

I just made a new pre-release which is merged to uBlock Origin's latest version 1.52.2, and it seems that the ads are not showing anymore, but requires more testing. Would be nice if you could also submit other possible issues with the application since I had to do these merges quite fast since this was an emergency with the ads showing.

https://github.com/dhowe/AdNauseam/releases/tag/v3.17.9b1

Let me know if the ads on youtube persist, and make sure the filter lists are updates.

(maybe its a good idea to install it on a separate browser profile, since this is a beta release)

I can give it a try. How can i install it?

U2C9727A4 commented 1 year ago

Ive attempted to install the beta extension that supposedly fixes this issue but have been unable to. (Unsigned extensions are not allowed even after doing about:config stuff)

mneunomne commented 1 year ago

Which browser you are using? If Firefox you need to set the debug mode and add temporary extension manually.

mneunomne commented 1 year ago

Tested more now and seems that this issue is now fixed on lastest pre-release / on master branch.

SkylerFur commented 1 year ago

https://github.com/dhowe/AdNauseam/releases/tag/v3.17.9b1

Let me know if the ads on youtube persist, and make sure the filter lists are updates.

Oop turns out I'm incompetent, completely buggered the whole thing up. Yes it seems to be working now.

U2C9727A4 commented 1 year ago

Which browser you are using? If Firefox you need to set the debug mode and add temporary extension manually.

Got it, thank you. Ill test it now

U2C9727A4 commented 1 year ago

Tested more now and seems that this issue is now fixed on lastest pre-release / on master branch.

I can confirm too, I no longer see ads. Hopefully a new stable release will be on mozilla addons shortly!

RowanSkie commented 1 year ago

Is it safe to use git pull/clone instead of me waiting for prereleases and stable releases? Brave/Chronium user here.

SkylerFur commented 1 year ago

Is it safe to use git pull/clone instead of me waiting for prereleases and stable releases? Brave/Chronium user here.

I mean like

https://github.com/dhowe/AdNauseam/releases/tag/v3.17.9b1

This is a pre-release you can use right now

RowanSkie commented 1 year ago

Is it safe to use git pull/clone instead of me waiting for prereleases and stable releases? Brave/Chronium user here.

I mean like

https://github.com/dhowe/AdNauseam/releases/tag/v3.17.9b1

This is a pre-release you can use right now

Either way, the advertisements have disappeared now.

JCD3nt0n commented 1 year ago

Confirming OOTB that v3.17.9b1 after +10 videos nothing is popping up. Further testing and adding my own lists at a later date to test on other platforms but so far on windows desktop Firefox 117.0.1 it just works™, will report in further details in a few hours.

Small update, updated Firefox to 180 and a few ads popped in on the main page with the default filters as exemplified here EDIT disreguard last update firefox just disabled the extension after update.

mneunomne commented 1 year ago

Thank you all for helping us with this and giving us updates. I have now submitted the new version (3.18.0) to the app stores and it should be available for auto-update soon.

JCD3nt0n commented 1 year ago

Welp I have a nasty update. Youtube is now including a new type of ad in my location (Portugal). It is Survey ads and that just bypasses the filter I didn't screenshot it but I'll try it next time it pops in.

mneunomne commented 1 year ago

@JCD3nt0n yes seems that uBlock Origin is currently trying to deal with all these new youtube approaches, but with this last AdNauseam release, at least we will be able to keep up with the new filters.

The reason why on AdNauseam all ads were appearing on youtube is because we didn't have the latest implementations of scriptlets, so the new filters added to the lists were not taking into effect on AdNauseam. Now if the filters keep updated, at least the ads on youtube will be hidden on the same way than uBlock Origin.

JCD3nt0n commented 1 year ago

Ah so it's going it's to them to solve the debacle, alright if the only thing bypassing it is the these types of newer ones and none of the other video based ones I will survive until they are done with the filters.

SkylerFur commented 1 year ago

So I'm pretty sure I've found a new YouTube Ad "bug" as I'm watching a video suddenly the audio cuts out, but seeking doesn't fix it. It's happening right about when a Mid-Roll ad should happen, I suspect that the video isn't being paused and the Ad isn't loading; however the audio is cut. The inverse of the Black video W/ Audio only Ads.

moving to new issue: #2408

dhowe commented 1 year ago

fixed in v3.18.0, thanks to @mneunomne closing for now