search

dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance
GNU General Public License v3.0
4.45k stars 187 forks source link

How to reset overlays on page? #2423

Open jackhagley opened 8 months ago

jackhagley commented 8 months ago

ISSUE

I create an overlay, but it accidentally hides elements that I want

WORKAROUND

turn off Ad Nauseam on page entirely This is not ideal

PROPOSED SOLUTION

Button in the dropdown menu "Reset overlays on this page" to return it to pre-blocked state

mneunomne commented 8 months ago

@jackhagley what exactly you mean by overlay? a cosmetic filter?

jackhagley commented 8 months ago

Sorry I mean I have used the right click context menu and blocked element(s). But as a human and a user I have made mistakes and therefore I would like an easy way to reset. Possibly there is a way to do this by removing strings somewhere, but this is not user friendly as some of the naming of these can be extremely opaque.

On Sun, Oct 15, 2023, 00:08 Alberto Harres @.***> wrote:

@jackhagley https://github.com/jackhagley what exactly you mean by overlay? a cosmetic filter?

— Reply to this email directly, view it on GitHub https://github.com/dhowe/AdNauseam/issues/2423#issuecomment-1763193857, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACTIKHOVJ7BWZGN77JWUXATX7MEPHAVCNFSM6AAAAAA577ZUVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRTGE4TGOBVG4 . You are receiving this because you were mentioned.Message ID: @.***>

mneunomne commented 8 months ago

I'm not sure if there is a good way to implement this. Because sometimes you could have added a cosmetic rule that is not domain-specific. on the uBlock menu you can disable the cosmetic filters on the current page. But I think the best way to reverse this is to simply delete the filters that were added in the "My Filters" tab in the dashboard.

dhowe commented 8 months ago

Seems the simplest answer would be to 'use the uBlock menu and disable the cosmetic filters on the current page', yes ?

If this is a solution, we could then discuss whether it makes sense to add a button...

mneunomne commented 8 months ago

I don't think it makes sense to add a button in this case. to have an UI button knowing there is a current filter in "my filters" matching the current domain string would require some unnecessary computing and de-compiling the 1p-filter just for 1 small feature.

jackhagley commented 8 months ago

I mean – it doesn't seem unnecessary to me, but as I won't be the one doing the work to make it happen, I take your point

mneunomne commented 8 months ago

Sorry @jackhagley I didn't mean it's an unnecessary feature, but an additional computing of filters on every page-load can be costly.

jackhagley commented 8 months ago

No problem at all :)