dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance
GNU General Public License v3.0
4.45k stars 187 forks source link

webRequestInternal.eventHandled #2450

Closed Novablox closed 7 months ago

Novablox commented 8 months ago

I tried to reproduce the issue when...

Description

Error in event handler: TypeError: Error in invocation of webRequestInternal.eventHandled(string eventName, string subEventName, string requestId, integer webViewInstanceId, optional webRequest.BlockingResponse response): Error at parameter 'response': Error at property 'responseHeaders': Invalid type: expected webRequest.HttpHeaders, found object.

URL(s) where the issue occurs.

No response

Screenshot(s)

jjjjj

Steps to Reproduce

No response

Configuration

default

mneunomne commented 7 months ago

I verify this is occurring, but I am currently not sure where this error is coming from... it's to find since I can't trace it to a specific function in adn. Perhaps need to rollback and see when this has started.

mneunomne commented 7 months ago

I can confirm this has started in v3.17.9b1 version, trying to find out why

mneunomne commented 7 months ago

Seems like it is being caused here:

https://github.com/dhowe/AdNauseam/blob/ae3ade5987b3a4671fa82a1e2ec712d2ac968e6b/src/js/traffic.js#L811-L813

and the function:

https://github.com/dhowe/AdNauseam/blob/ae3ade5987b3a4671fa82a1e2ec712d2ac968e6b/src/js/traffic.js#L1262-L1288

mneunomne commented 7 months ago

This commit:

https://github.com/dhowe/AdNauseam/commit/5ebdbf3e24393560156fdcd931e31f901471f7f3

mneunomne commented 7 months ago

Fixing with https://github.com/dhowe/AdNauseam/pull/2471 The issue was how the adnOnHeadersRecieved function was being returned

return {responseHeaders: headers}

instead of

return responseHeaders
mneunomne commented 7 months ago

Fixed, closing