search

dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance
GNU General Public License v3.0
4.45k stars 187 forks source link

Disable button on Menu not working on certain urls #2454

Closed mneunomne closed 7 months ago

mneunomne commented 7 months ago

Based on what was shared in this discussion thread, there is a bug on the 'disabled' button which I have now just confirmed. It not happening on all pages, investigating why.

where bug is present:

nytimes.com

where is not

g1.globo.com
mneunomne commented 7 months ago

I understood the issue now.

It seems that now "disable on current page" option should be possible when you are at the home of the domain, for example:

https://nytimes.com/

It should only be possible when we are at some specific page :

https://www.nytimes.com/2023/11/08/world/middleeast/hamas-israel-gaza-war.html

THis was causing a bug where one couldn't disable that domain anymore because of an errouneus entry to the 'trusted sites' tab.

I will disable the "on this page" option when the user is at the home of the domain.

dhowe commented 7 months ago

This may be difficult/impossible to detect in some cases, so please verify sensible default behavior/messaging when we are on a specific/unique page with a URL containing only a domain (which would incorrectly register as a 'home' page)

mneunomne commented 7 months ago

How ublock implements it, is that if you are on 'home' page of a domain, you don't have the option to disable only on page, and only allows for 'domain' disable instead. I thought this behaviour would be sensible?

mneunomne commented 7 months ago

This is now fixed, closing.