dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance
GNU General Public License v3.0
4.45k stars 187 forks source link

Context-menu disappears #2528

Closed dhowe closed 1 month ago

dhowe commented 3 months ago

Description

Context-menu disappears after failing to block element

Screenshot(s)

image

Configuration

AdNauseam: 3.21.0 Firefox: 124 filterset (summary): network: 126254 cosmetic: 129865 scriptlet: 30713 html: 1986 listset (total-discarded, last-updated): added: adguard-cookies: 29114-60, 1d.8h.1m ublock-cookies-adguard: 1062-0, 3d.17h.11m adguard-other-annoyances: 14105-385, 3d.8h.35m easylist-annoyances: 4453-21, 4d.11h.12m fanboy-cookiemonster: 50769-3883, 1d.3h.1m ublock-cookies-easylist: 1062-1055, 3d.17h.10m ublock-annoyances: 6884-1090, 1h.26m Δ default: user-filters: 20-3, never adnauseam-filters: 538-2, 3d.17h.11m eff-dnt-whitelist: 616-0, 1d.23h.16m ublock-filters: 37467-110, 1h.26m Δ ublock-badware: 8053-15, 3d.45m ublock-privacy: 777-0, 1h.26m Δ ublock-unbreak: 2297-0, 1h.26m Δ ublock-quick-fixes: 214-0, 7h.27m easylist: 84408-454, 1h.26m Δ easyprivacy: 50427-84, 1h.26m Δ urlhaus-1: 3798-1, 6h.27m filterset (user): [array of 20 redacted] trustedset: added: [array of 12 redacted] userSettings: admap: [redacted] firstInstall: false hidingAds: true clickingAds: true blockingMalware: true disableHidingForDNT: true clickProbability: 0.65 hiddenSettings: [none] supportStats: allReadyAfter: 79098 ms (selfie) maxAssetCacheWait: 8819 ms cacheBackend: indexedDB

mneunomne commented 1 month ago

@dhowe what do you mean by "failing to block element" ?

dhowe commented 1 month ago

I believe that I right-clicked 'block element', the element was not blocked, and the option disappeared from the context menu

mneunomne commented 1 month ago

any errors in the logs?

dhowe commented 1 month ago

not sure - when I try to recreate the issue the block works, however the context-menu changes from reading 'adnauseam' to reading 'block element' -- what is the correct label ?

mneunomne commented 1 month ago

This depends if you are clicking inside an iframe or not. When clicking in iframe, there is option to "block element in frame" or "block element". Is that your case?

Screenshot 2024-05-06 at 10 59 44

dhowe commented 1 month ago

both cases on that page -- I'll keep an eye out for the problem in the future and we can re-open