dhowe / AdNauseam

AdNauseam: Fight back against advertising surveillance
GNU General Public License v3.0
4.61k stars 191 forks source link

AdNauseam 3.21.4 shows welcome switch page on ever launch of Firefox #2536

Open apoapostolov opened 6 months ago

apoapostolov commented 6 months ago

I tried to reproduce the issue when...

Description

Since update to the latest version, every time I restart the browser, AdNauseam shows the webcome screen with the three major switches turned off and I have to turn them each time for the extension to work.

URL(s) where the issue occurs.

No response

Screenshot(s)

No response

Steps to Reproduce

No response

Configuration

Windows, Firefox 128a1

mneunomne commented 5 months ago

Sounds like a corrupted data file in the firefox profile. @apoapostolov could you please test it on a fresh firefox profile?

jas01 commented 5 months ago

I got the same issue. I try installing AdNauseam on the same computer after a mv .mozilla .mozilla_orig and it's work, no bug after the installation, and restart, no need to reconfigure. But because I'm not the only one, I guessing the probability that two persons got the exact same corruption are not big Beside AdNauseam I've also got : uBlock Origin, Privacy Badger, Tridactyl and Dark Reader.

I don't have any warning when I'm starting firefox, so I don't even know how to check if my profile are corrupted.

dhowe commented 5 months ago

@jas01 best thing would be to create a fresh firefox profile and test if the problem persists...

jas01 commented 5 months ago

@jas01 best thing would be to create a fresh firefox profile and test if the problem persists...

Yes I did, I what I mean when I say I launch mv .mozilla .mozilla.orig and yes the problem disappear. But my point is I don't have any warning about corrupt profile.

teejo75 commented 4 months ago

I'm also having this issue, although i don't get the welcome, I have to manually enable the three switches before ad nauseum works again. This is with FF 128.

I can confirm that a new FF profile seems to fix this issue.

dhowe commented 4 months ago

If anyone has thoughts on how to detect corrupt profiles (or in what way they are corrupt), would be great to hear

mneunomne commented 4 months ago

It can either be a problem with the profile itself, or something wrong with the data storage of adnauseam itself.

Maybe someone who is experiencing the issue can help?

If go to the console of adnauseam on firefox:

about:debugging#/runtime/this-firefox -> adnauseam -> inspect

perhaps you can paste this code and see if all the storage currently exists, and if all the keys are there:

browser.storage.local.get(null).then(items => {
  const allKeys = Object.keys(items);
  console.log(allKeys); // Logs all keys
});

where a correct output would be something like this:

0: "admap"
1: "allowedRequestCount"
2: "assetCacheRegistry"
3: "assetSourceRegistry"
4: "availableFilterLists"
5: "blockedRequestCount"
6: "blockingMalware"
7: "cache/adnauseam-filters"
8: "cache/assets.json"
9: "cache/compiled/adnauseam-filters"
10: "cache/compiled/easylist"
11: "cache/compiled/easyprivacy"
12: "cache/compiled/eff-dnt-whitelist"
13: "cache/compiled/ublock-badware"
14: "cache/compiled/ublock-filters"
15: "cache/compiled/ublock-privacy"
16: "cache/compiled/ublock-quick-fixes"
17: "cache/compiled/ublock-unbreak"
18: "cache/compiled/urlhaus-1"
19: "cache/compiled/user-filters"
20: "cache/easylist"
21: "cache/easyprivacy"
22: "cache/eff-dnt-whitelist"
23: "cache/public_suffix_list.dat"
24: "cache/selfie/public_suffix_list.dat"
25: "cache/selfie/redirectEngine/resources"
26: "cache/selfie/staticExtFilteringEngine"
27: "cache/selfie/staticMain"
28: "cache/selfie/staticNetFilteringEngine"
29: "cache/ublock-badlists"
30: "cache/ublock-badware"
31: "cache/ublock-filters"
32: "cache/ublock-privacy"
33: "cache/ublock-quick-fixes"
34: "cache/ublock-unbreak"
35: "cache/urlhaus-1"
36: "cachedManagedStorage"
37: "clickingAds"
38: "compiledMagic"
39: "disableClickingForDNT"
40: "disableHidingForDNT"
41: "dntDomains"
42: "eventLogging"
43: "firstInstall"
44: "hiddenSettings"
45: "hidingAds"
46: "hostnameSwitchesString"
47: "importedLists"
48: "localStorage"
49: "netStrictBlockList"
50: "netWhitelist"
51: "requestStats"
52: "selectedFilterLists"
53: "selfieMagic"
54: "user-filters"
55: "version"
56: "versionUpdateTime"
length: 57
<prototype>: Array []
teejo75 commented 4 months ago

This is the object from my broken adnauseum profile:

[
  "admap",
  "allowedRequestCount",
  "assetCacheRegistry",
  "assetSourceRegistry",
  "availableFilterLists",
  "blockedRequestCount",
  "blockingMalware",
  "cache/adguard-cookies",
  "cache/adguard-generic",
  "cache/adguard-mobile-app-banners",
  "cache/adguard-other-annoyances",
  "cache/adguard-popup-overlays",
  "cache/adguard-social",
  "cache/adguard-spyware",
  "cache/adguard-widgets",
  "cache/adnauseam-filters",
  "cache/compiled/adguard-cookies",
  "cache/compiled/adguard-generic",
  "cache/compiled/adguard-mobile-app-banners",
  "cache/compiled/adguard-other-annoyances",
  "cache/compiled/adguard-popup-overlays",
  "cache/compiled/adguard-social",
  "cache/compiled/adguard-spyware",
  "cache/compiled/adguard-widgets",
  "cache/compiled/adnauseam-filters",
  "cache/compiled/easylist",
  "cache/compiled/easylist-annoyances",
  "cache/compiled/easylist-newsletters",
  "cache/compiled/easylist-notifications",
  "cache/compiled/easyprivacy",
  "cache/compiled/fanboy-cookiemonster",
  "cache/compiled/fanboy-social",
  "cache/compiled/fanboy-thirdparty_social",
  "cache/compiled/plowe-0",
  "cache/compiled/ublock-annoyances",
  "cache/compiled/ublock-badware",
  "cache/compiled/ublock-cookies-adguard",
  "cache/compiled/ublock-cookies-easylist",
  "cache/compiled/ublock-filters",
  "cache/compiled/ublock-privacy",
  "cache/compiled/ublock-quick-fixes",
  "cache/compiled/ublock-unbreak",
  "cache/compiled/urlhaus-1",
  "cache/compiled/user-filters",
  "cache/easylist",
  "cache/easylist-annoyances",
  "cache/easylist-newsletters",
  "cache/easylist-notifications",
  "cache/easyprivacy",
  "cache/fanboy-cookiemonster",
  "cache/fanboy-social",
  "cache/fanboy-thirdparty_social",
  "cache/plowe-0",
  "cache/public_suffix_list.dat",
  "cache/selfie/public_suffix_list.dat",
  "cache/selfie/redirectEngine/resources",
  "cache/ublock-annoyances",
  "cache/ublock-badlists",
  "cache/ublock-badware",
  "cache/ublock-cookies-adguard",
  "cache/ublock-cookies-easylist",
  "cache/ublock-filters",
  "cache/ublock-privacy",
  "cache/ublock-quick-fixes",
  "cache/ublock-unbreak",
  "cache/urlhaus-1",
  "cachedManagedStorage",
  "clickingAds",
  "cloudStorageEnabled",
  "compiledMagic",
  "dntDomains",
  "dynamicFilteringString",
  "externalLists",
  "firstInstall",
  "hiddenSettings",
  "hidingAds",
  "hostnameSwitchesString",
  "importedLists",
  "lastBackupFile",
  "lastBackupTime",
  "lastRestoreFile",
  "lastRestoreTime",
  "localStorage",
  "netStrictBlockList",
  "netWhitelist",
  "popupPanelSections",
  "requestStats",
  "selectedFilterLists",
  "selfieMagic",
  "urlFilteringString",
  "user-filters",
  "version",
  "versionUpdateTime"
]

And this is the object from my working profile. I'm not using exactly the same filter lists in the new one, but my personal rules etc are the same.

[
  "admap",
  "assetCacheRegistry",
  "assetSourceRegistry",
  "availableFilterLists",
  "blockingMalware",
  "cache/adguard-cookies",
  "cache/adguard-generic",
  "cache/adguard-mobile-app-banners",
  "cache/adguard-other-annoyances",
  "cache/adguard-popup-overlays",
  "cache/adguard-spyware",
  "cache/adguard-spyware-url",
  "cache/adguard-widgets",
  "cache/adnauseam-filters",
  "cache/assets.json",
  "cache/block-lan",
  "cache/compiled/adguard-cookies",
  "cache/compiled/adguard-generic",
  "cache/compiled/adguard-mobile-app-banners",
  "cache/compiled/adguard-other-annoyances",
  "cache/compiled/adguard-popup-overlays",
  "cache/compiled/adguard-spyware",
  "cache/compiled/adguard-spyware-url",
  "cache/compiled/adguard-widgets",
  "cache/compiled/adnauseam-filters",
  "cache/compiled/block-lan",
  "cache/compiled/curben-phishing",
  "cache/compiled/easylist",
  "cache/compiled/easylist-annoyances",
  "cache/compiled/easylist-chat",
  "cache/compiled/easylist-newsletters",
  "cache/compiled/easylist-notifications",
  "cache/compiled/easyprivacy",
  "cache/compiled/eff-dnt-whitelist",
  "cache/compiled/fanboy-cookiemonster",
  "cache/compiled/plowe-0",
  "cache/compiled/ublock-annoyances",
  "cache/compiled/ublock-badware",
  "cache/compiled/ublock-cookies-adguard",
  "cache/compiled/ublock-cookies-easylist",
  "cache/compiled/ublock-filters",
  "cache/compiled/ublock-privacy",
  "cache/compiled/ublock-quick-fixes",
  "cache/compiled/ublock-unbreak",
  "cache/compiled/urlhaus-1",
  "cache/compiled/user-filters",
  "cache/curben-phishing",
  "cache/easylist",
  "cache/easylist-annoyances",
  "cache/easylist-chat",
  "cache/easylist-newsletters",
  "cache/easylist-notifications",
  "cache/easyprivacy",
  "cache/eff-dnt-whitelist",
  "cache/fanboy-cookiemonster",
  "cache/plowe-0",
  "cache/public_suffix_list.dat",
  "cache/selfie/public_suffix_list.dat",
  "cache/selfie/redirectEngine/resources",
  "cache/selfie/staticExtFilteringEngine",
  "cache/selfie/staticMain",
  "cache/selfie/staticNetFilteringEngine",
  "cache/ublock-annoyances",
  "cache/ublock-badlists",
  "cache/ublock-badware",
  "cache/ublock-cookies-adguard",
  "cache/ublock-cookies-easylist",
  "cache/ublock-filters",
  "cache/ublock-privacy",
  "cache/ublock-quick-fixes",
  "cache/ublock-unbreak",
  "cache/urlhaus-1",
  "cachedManagedStorage",
  "clickingAds",
  "compiledMagic",
  "disableClickingForDNT",
  "disableHidingForDNT",
  "dntDomains",
  "firstInstall",
  "hidingAds",
  "importedLists",
  "localStorage",
  "netStrictBlockList",
  "netWhitelist",
  "requestStats",
  "selectedFilterLists",
  "selfieMagic",
  "user-filters",
  "version",
  "versionUpdateTime"
]

There are some differences to the keys, ignoring the cache entries. I'm not sure if this helps at all.

For what it's worth, I didn't have any indication that there was anything wrong with my firefox profile other than requiring to enable the three main adnauseum settings every time I started firefox.

Screenshot: image

mneunomne commented 4 months ago

Then it seems that the problem is not with the storage bring broken somehow. Indeed seems to be that the extension can't write/read the data from the firefox profile. Need to try to reproduce this so I can test at least.

apoapostolov commented 3 months ago

On my side, the code causes error

browser.storage.local.get(null).then(items => {
  const allKeys = Object.keys(items);
  console.log(allKeys); // Logs all keys
});
Promise { <state>: "pending" }
​
<state>: "rejected"
​
<reason>: Error: An unexpected error occurred
​​
columnNumber: 1
​​
fileName: "undefined"
​​
lineNumber: 0
​​
message: "An unexpected error occurred"
​​
stack: ""
​​
<prototype>: Error.prototype { stack: "", … }
​​​
constructor: function Error()
​​​
message: ""
​​​
name: "Error"
​​​
stack: ""
​​​
toString: function toString()
​​​
<get stack()>: function stack()
​​​
<set stack()>: function stack()
​​​
<prototype>: Object { … }
​
<prototype>: Promise.prototype { … }
​​
catch: function catch()
​​
constructor: function Promise()
​​
finally: function finally()
​​
then: function then()
​​
Symbol(Symbol.toStringTag): "Promise"
​​
<prototype>: Object { … }

Is there a way to fully reset the extension?

kirelagin commented 2 months ago

I’ve been having this problem too, I think, since the last update of the extension. There are also a couple of reports on Reddit.

Here is my output:

``` 0: "admap" ​ 1: "advancedUserEnabled" ​ 2: "allowedRequestCount" ​ 3: "alwaysDetachLogger" ​ 4: "assetCacheRegistry" ​ 5: "autoUpdate" ​ 6: "availableFilterLists" ​ 7: "blockedRequestCount" ​ 8: "blockingMalware" ​ 9: "cache/adnauseam-filters" ​ 10: "cache/compiled/adnauseam-filters" ​ 11: "cache/compiled/easylist" ​ 12: "cache/compiled/easyprivacy" ​ 13: "cache/compiled/eff-dnt-whitelist" ​ 14: "cache/compiled/ublock-badware" ​ 15: "cache/compiled/ublock-filters" ​ 16: "cache/compiled/ublock-privacy" ​ 17: "cache/compiled/ublock-quick-fixes" ​ 18: "cache/compiled/ublock-unbreak" ​ 19: "cache/compiled/urlhaus-1" ​ 20: "cache/easylist" ​ 21: "cache/easyprivacy" ​ 22: "cache/eff-dnt-whitelist" ​ 23: "cache/public_suffix_list.dat" ​ 24: "cache/selfie/public_suffix_list.dat" ​ 25: "cache/selfie/redirectEngine/resources" ​ 26: "cache/selfie/staticExtFilteringEngine" ​ 27: "cache/selfie/staticMain" ​ 28: "cache/selfie/staticNetFilteringEngine" ​ 29: "cache/ublock-badlists" ​ 30: "cache/ublock-badware" ​ 31: "cache/ublock-filters" ​ 32: "cache/ublock-privacy" ​ 33: "cache/ublock-quick-fixes" ​ 34: "cache/ublock-unbreak" ​ 35: "cache/urlhaus-1" ​ 36: "cachedManagedStorage" ​ 37: "clickOnlyWhenIdleFor" ​ 38: "clickProbability" ​ 39: "clickingAds" ​ 40: "cloudStorageEnabled" ​ 41: "cnameUncloakEnabled" ​ 42: "collapseBlocked" ​ 43: "colorBlindFriendly" ​ 44: "compiledMagic" ​ 45: "contextMenuEnabled" ​ 46: "disableClickingForDNT" ​ 47: "disableHidingForDNT" ​ 48: "disableWarnings" ​ 49: "dntDomains" ​ 50: "eventLogging" ​ 51: "externalLists" ​ 52: "firewallPaneMinimized" ​ 53: "firstInstall" ​ 54: "hidingAds" ​ 55: "hyperlinkAuditingDisabled" ​ 56: "ignoreGenericCosmeticFilters" ​ 57: "importedLists" ​ 58: "largeMediaSize" ​ 59: "localStorage" ​ 60: "netWhitelist" ​ 61: "noIncomingCookies" ​ 62: "noOutgoingCookies" ​ 63: "noOutgoingReferer" ​ 64: "noOutgoingUserAgent" ​ 65: "parseAllABPHideFilters" ​ 66: "parseTextAds" ​ 67: "popupPanelSections" ​ 68: "prefetchingDisabled" ​ 69: "removeAdsInPrivate" ​ 70: "requestLogMaxEntries" ​ 71: "requestStats" ​ 72: "selectedFilterLists" ​ 73: "selfieMagic" ​ 74: "showIconBadge" ​ 75: "strictBlockingMode" ​ 76: "suspendUntilListsAreLoaded" ​ 77: "tooltipsDisabled" ​ 78: "uiAccentCustom" ​ 79: "uiAccentCustom0" ​ 80: "uiTheme" ​ 81: "userFiltersTrusted" ​ 82: "version" ​ 83: "versionUpdateTime" ​ 84: "webrtcIPAddressHidden" ​ length: 85 ```
dhowe commented 2 months ago

@mneunomne pls check into this... thank you

mneunomne commented 2 months ago

@kirelagin @apoapostolov or anyone else with this issue could you please backup + download your adnauseam settings + ads and send it to me alberto.harres at gmail.com? I was not able to reproduce this issue myself and perhaps this is the only way I can at least try to see if there is any issue in the storage data.

kirelagin commented 2 months ago

@mneunomne Sent. I suspect there is nothing interesting in there, it’s pretty much the defaults.

kirelagin commented 2 months ago

If I go to the support tab immediately after restarting the web browser, here is what I see:

AdNauseam: 3.22.0
Firefox: 123
filterset (summary):
 network: 138326
 cosmetic: 48853
 scriptlet: 21020
 html: 1994
listset (total-discarded, last-updated):
 default:
  user-filters: 0-0, never
  adnauseam-filters: 547-2, 2d.13h.56m
  eff-dnt-whitelist: 568-0, 1h.10m
  ublock-filters: 40595-138, 1h.10m Δ
  ublock-badware: 11323-6, 1h.9m
  ublock-privacy: 1243-22, 1h.10m Δ
  ublock-unbreak: 2537-1, 1h.10m Δ
  ublock-quick-fixes: 133-4, 1h.10m
  easylist: 85520-203, 1h.10m Δ
  easyprivacy: 53090-63, 1h.10m Δ
  urlhaus-1: 15151-0, 1h.10m
filterset (user): [empty]
trustedset:
 added: [array of 7 redacted]
userSettings:
 firstInstall: false
hiddenSettings: [none]
supportStats:
 allReadyAfter: 1828 ms
 maxAssetCacheWait: 203 ms
 cacheBackend: indexedDB

(and it is showing the three bars at the top suggesting a reactivate ad hiding, ad clicking, and malware blocking).

kirelagin commented 2 months ago

When I check the console of the extension immediately after restart, there is this:

Error: An unexpected error occurred [vapi-background.js:141:21](moz-extension://3da6ae95-985a-4666-8bd8-6abab16941b0/js/vapi-background.js)

(and there is no additional info about what exactly has happened).

After that, there is this:

console

stevenege commented 1 month ago

Sent my backup as requested, this issue started about a week ago for me. Restarting the PC produces the reset, once turned back on it works fine. The as vault doesn't load anymore either, just perpetual loading.

depwl9992 commented 4 weeks ago

Seeing this issue on v3.23.2 (FF 131.0.3, 64-bit) - every fresh start of Firefox opens a new tab with the initial "Hide Ads/Click Ads/Block Malware" switch page, all defaulting to OFF.

I can do some debugging later, but for now I'm just throwing my name into the "me too, here's my current version" list.