search

dhowe / AdNauseamV1

*** This is not the current AdNauseam repository: please find the current repo here:
https://github.com/dhowe/AdNauseam
GNU General Public License v3.0
385 stars 33 forks source link

menu: new ads detected but showing 'No ads on this page' on duckduckgo.com #311

Closed CyrusSUEN closed 9 years ago

CyrusSUEN commented 9 years ago

steps to reproduce:

  1. Go to https://duckduckgo.com/?q=credit+card&t=ffsb&ia=about 2 ads shall be correctly identified. 1
  2. search for keyword e.g. 'gym' from duckduckgo search bar from the website in current tab New ad is detected but Menu shows 'No ads on this page' 2
dhowe commented 9 years ago

Verified. Note that this happens because DDG resets the url after the page is loading (adding '&ia=about'). I've implemented a temporary fix (partial-matching), but make a note if you see this happening on any other site (a warning will be output in the console/log).

CyrusSUEN commented 9 years ago

fix verified

CyrusSUEN commented 9 years ago

Problem reappears:

To go www.duckduckgo.com Search for keywords that come with text ads (e.g. credit card) on the search box of the website.

screen shot 2015-07-27 at 5 47 03 pm

CyrusSUEN commented 9 years ago

Please verify: https://github.com/dhowe/AdNauseam/pull/416