search

dhowe / AdNauseamV1

*** This is not the current AdNauseam repository: please find the current repo here:
https://github.com/dhowe/AdNauseam
GNU General Public License v3.0
385 stars 33 forks source link

Menu should empty when ADN is disabled (and badge should disappear) #317

Closed dhowe closed 9 years ago

dhowe commented 9 years ago

and should remain empty if re-opened

but should refill with ads when ADN is unpaused

screen shot 2015-05-13 at 9 05 36 pm

dhowe commented 9 years ago

please verify

CyrusSUEN commented 9 years ago

Verified.

But I think the badge of 'VIEW AD VAULT' button should be gone or keep the original count number instead of showing 0. What do you think?

dhowe commented 9 years ago

Or perhaps grayed-out...

CyrusSUEN commented 9 years ago

Does gray-ing out means the button becomes unclickable?

I think it's better to keep the original count number. Because we are to "pause ADN" instead of disabling it. Like pausing a video, a viewer can still keep staring at the latest frame. After pausing ADN a user should be able to check out the latest Ad Vault.

change line 253 of menu.js to the following should do the job

total = json.totalCount,
dhowe commented 9 years ago

But what happens when user goes to the next page? ADN is paused, so it does not know the number of ads on this page; it can either show the previous count (now incorrect), or show zero, or nothing. Perhaps best to hide the numbers altogether when ADN is paused...

CyrusSUEN commented 9 years ago

screen shot 2015-05-19 at 2 21 03 am What about this? I think showing this is better than 0.

Feel free to accept or decline this change: https://github.com/dhowe/AdNauseam/pull/324

CyrusSUEN commented 9 years ago

OK. Closed.