dhowe / AdNauseamV1

*** This is not the current AdNauseam repository: please find the current repo here:
https://github.com/dhowe/AdNauseam
GNU General Public License v3.0
385 stars 33 forks source link

PageMod not calling onAttach on Firefox 39 #402

Closed dhowe closed 7 years ago

dhowe commented 9 years ago

screen shot 2015-07-15 at 6 21 36 pm

dhowe commented 9 years ago

To debug, run the addon via cfx. Make sure that the 'automated' preference is set to 'true' (see below). Then view the console or log to see that the first log-message appears, but not the second.

screen shot 2015-07-15 at 6 24 55 pm

CyrusSUEN commented 9 years ago

Situation update: no problem on Firefox 37 and 38. Problem only exists on Firefox 39.

dhowe commented 9 years ago

Ok, well, first thing to do is to run the test on FF 38, and check the results. Then we can investigate what changed in 39...

CyrusSUEN commented 9 years ago

Tested with Firefox 38 Filter lists (as of 15/7/15 6:24pm): EasyList Malware Domains Fanboy's Social Blocking List EasyPrivacy

And unchecked "Allow some non-intrusive advertising"

https://gist.github.com/dhowe/68bd5570488bf04b1349 (TXT) https://gist.github.com/dhowe/0e5833df9f31c62034c1 (JSON)

The result JSON currently has only 63 entries instead of 184 because the test was interrupted and I did a second run for the remaining 63.

dhowe commented 9 years ago

Lets not paste so much text into our issues (see above). Also, the # of zero-counts seems very high, can you compute the percent of zero-results? And test a few of these manually to compare

CyrusSUEN commented 9 years ago

Firefox 38 default settings except:

AdBlock Plus default settings except:

AdNauseam default settings

Filter lists used in AdBlock Plus :

Result:

dhowe commented 9 years ago

text-ads: ask, ebay, yahoo?

CyrusSUEN commented 9 years ago

text-ads: ask, ebay, yahoo?

No ad filter list for yahoo - the original EasyList does NOT block any ads from yahoo's search result page

The text ad detection on ebay and ask is old problem

dhowe commented 9 years ago

is there a ticket?

CyrusSUEN commented 9 years ago

Ask.com: https://github.com/dhowe/AdNauseam/issues/200

dhowe commented 9 years ago

Lets move to a separate ticket for failing text ads... Is there any list for yahoo ads? If not, then we don't need the regex

CyrusSUEN commented 9 years ago

Is there any list for yahoo ads? If not, then we don't need the regex

Think we can keep the regex.

There used to be a filter list for yahoo ads. Not sure why it went missing. This kind of things had happened before. The filter rule for Sogou text ad was missing and I reported to the forum of EasyList China.

Just submitted a report to EasyList forum (link to my post is not available yet until approved) https://forums.lanik.us/viewforum.php?f=62

CyrusSUEN commented 9 years ago

As of 10th Aug, 2015 using the latest EasyList filter, ADP for Firefox still cannot detect text ads on https://search.yahoo.com/search;_ylt=A2KK_KhKYMhVJSUAM6ebvZx4?p=credit+card&toggle=1&cop=mss&ei=UTF-8&fr=yfp-t-901&fp=1