Closed dhowe closed 7 years ago
To debug, run the addon via cfx. Make sure that the 'automated' preference is set to 'true' (see below). Then view the console or log to see that the first log-message appears, but not the second.
Situation update: no problem on Firefox 37 and 38. Problem only exists on Firefox 39.
Ok, well, first thing to do is to run the test on FF 38, and check the results. Then we can investigate what changed in 39...
Tested with Firefox 38 Filter lists (as of 15/7/15 6:24pm): EasyList Malware Domains Fanboy's Social Blocking List EasyPrivacy
And unchecked "Allow some non-intrusive advertising"
https://gist.github.com/dhowe/68bd5570488bf04b1349 (TXT) https://gist.github.com/dhowe/0e5833df9f31c62034c1 (JSON)
The result JSON currently has only 63 entries instead of 184 because the test was interrupted and I did a second run for the remaining 63.
Lets not paste so much text into our issues (see above). Also, the # of zero-counts seems very high, can you compute the percent of zero-results? And test a few of these manually to compare
Firefox 38 default settings except:
AdBlock Plus default settings except:
AdNauseam default settings
Filter lists used in AdBlock Plus :
Result:
text-ads: ask, ebay, yahoo?
text-ads: ask, ebay, yahoo?
No ad filter list for yahoo - the original EasyList does NOT block any ads from yahoo's search result page
The text ad detection on ebay and ask is old problem
is there a ticket?
Lets move to a separate ticket for failing text ads... Is there any list for yahoo ads? If not, then we don't need the regex
Is there any list for yahoo ads? If not, then we don't need the regex
Think we can keep the regex.
There used to be a filter list for yahoo ads. Not sure why it went missing. This kind of things had happened before. The filter rule for Sogou text ad was missing and I reported to the forum of EasyList China.
Just submitted a report to EasyList forum (link to my post is not available yet until approved) https://forums.lanik.us/viewforum.php?f=62
As of 10th Aug, 2015 using the latest EasyList filter, ADP for Firefox still cannot detect text ads on https://search.yahoo.com/search;_ylt=A2KK_KhKYMhVJSUAM6ebvZx4?p=credit+card&toggle=1&cop=mss&ei=UTF-8&fr=yfp-t-901&fp=1