dhowe / ChinaEye

Experience the web as if you were living in China...
Artistic License 2.0
9 stars 3 forks source link

Feature: Show individual server responses in menu #23

Closed dhowe closed 7 years ago

dhowe commented 7 years ago

better design needed

screen shot 2017-02-11 at 2 02 25 pm

cqx931 commented 7 years ago

image

cqx931 commented 7 years ago

Do we only shows the server info if the page is blocked?

dhowe commented 7 years ago

Looks really good! No, we can show server info whenever the user clicks on the menu 'Disable for search' should only activate when the user has searched Where does the 'great firewall of china' link to?

cqx931 commented 7 years ago

Currently I "Disable for search" only shows up if ChinaEye is on search result page and there it is active for search. If the user search on a search engine and the keyword matches with one of the triggers, the page won't be checked from the server at all. Should the server response display collapse for this case or should ChinaEye always check this info? I suppose "great firewall of china" should link to http://www.greatfirewallofchina.org/ as we are getting the server info from them.

dhowe commented 7 years ago

"Disable for search" only shows up if ChinaEye is on search result page

Hmm, maybe for search pages we just show the green for all servers (since we know they are not blocked), but don't actually do the search

"great firewall of china" should link to http://www.greatfirewallofchina.org/

Lets move the great firewall link to the bottom, and make it smaller

cqx931 commented 7 years ago

image

dhowe commented 7 years ago

Cool. So are we disabling by site (hostname) now?

cqx931 commented 7 years ago

yes, either by hostname or by search keyword.

cqx931 commented 7 years ago

This feature is now live: https://github.com/dhowe/ChinaEye/pull/36