Closed dhowe closed 7 years ago
Do we only shows the server info if the page is blocked?
Looks really good! No, we can show server info whenever the user clicks on the menu 'Disable for search' should only activate when the user has searched Where does the 'great firewall of china' link to?
Currently I "Disable for search" only shows up if ChinaEye is on search result page and there it is active for search.
If the user search on a search engine and the keyword matches with one of the triggers, the page won't be checked from the server at all. Should the server response display collapse for this case or should ChinaEye always check this info?
I suppose "great firewall of china" should link to http://www.greatfirewallofchina.org/
as we are getting the server info from them.
"Disable for search" only shows up if ChinaEye is on search result page
Hmm, maybe for search pages we just show the green for all servers (since we know they are not blocked), but don't actually do the search
"great firewall of china" should link to http://www.greatfirewallofchina.org/
Lets move the great firewall link to the bottom, and make it smaller
Cool. So are we disabling by site (hostname) now?
yes, either by hostname or by search keyword.
This feature is now live: https://github.com/dhowe/ChinaEye/pull/36
better design needed