search

dhowe / ChinaEye

Experience the web as if you were living in China...
Artistic License 2.0
9 stars 3 forks source link

Check TODO: items in source #26

Closed dhowe closed 7 years ago

dhowe commented 7 years ago

some questions, some suggested changes... some for discussion

cqx931 commented 7 years ago

TODO:do some valid keywords have only one part, or should we ignore them as invalid

If a keyword only have one part, it is still valid, it just means that it doesn't have a corresponding English translation in the document.

dhowe commented 7 years ago

one questions like this are answered, feel free to remove the corresponding TODO at your convenience

cqx931 commented 7 years ago

// TODO: if just installed, how can there be triggers in local storage?

https://github.com/dhowe/ChinaEye/pull/31/commits/f370d7880978661f664f7972f8d374fb16ad7ced

// TODO: make sure that our style tag is not being added multiple times on the same page

https://github.com/dhowe/ChinaEye/pull/31/commits/f7fad0580fef36b862c8e02fe0e6ba0dd0bae0e4

all done, please check.