Should we store the blocking status of all the tabs in current Window?

dhowe / ChinaEye

Experience the web as if you were living in China...

Artistic License 2.0

9 stars 3 forks source link

Should we store the blocking status of all the tabs in current Window? #35

Closed cqx931 closed 7 years ago

cqx931 commented 7 years ago

https://github.com/dhowe/ChinaEye/blob/master/js/background.js#L290 The icon should be updated whenever the current tab changes, but it doesn't make sense to run through the keyword and page check again to get the blocking status of a specific tab that has already been loaded.

tabId: 
{
tabUrl : url,
blockingStatus: status
}

dhowe commented 7 years ago

yes, good plan

cqx931 commented 7 years ago

Checked in here: https://github.com/dhowe/ChinaEye/pull/36