search

dhowe / ChinaEye

Experience the web as if you were living in China...
Artistic License 2.0
9 stars 3 forks source link

Handle 'timeout' fails appropriately #40

Closed dhowe closed 7 years ago

dhowe commented 7 years ago

In this case, on Chrome, ChinaEye shows the page redacted, but GFW shows 'timeout'. Is this a valid response?

If so, perhaps it should get a yellow color, but not redacted? Same I think for anytime ANY of the servers is not green.

image

cqx931 commented 7 years ago

https://github.com/dhowe/ChinaEye/blob/master/js/background.js#L438 Currently, ChinaEye only block a page if there are more than two servers failed in the test. When I test the case on greatfirewallofchina.org, I got all fails as result. Can the timeout result be some server issues of Greatfirewallofchina? I have added a yellow tag to display the server result if it is neither "fail" nor "ok".

cqx931 commented 7 years ago

This can be closed for now.